Changeset 203923 in webkit for trunk/Source/JavaScriptCore/dfg/DFGMaximalFlushInsertionPhase.cpp

Timestamp:

Jul 29, 2016, 3:04:02 PM (9 years ago)

Author:

[email protected]

Message:

Refactor DFG::Node::hasLocal() to accessesStack()
​https://bugs.webkit.org/show_bug.cgi?id=160357

Reviewed by Filip Pizlo.

Refactoring in preparation for using register arguments for JavaScript calls.

Renamed Node::hasLocal() to Node::accessesStack() and changed all uses accordingly.
Also changed uses of Node::hasVariableAccessData() to accessesStack() where that
use guards stack operation logic associated with the Node's VariableAccessData.

The hasVariableAccessData() check now implies no more than the node has a
VariableAccessData and nothing about its use of that data to coordinate stack
accesses.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

• dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock):

• dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):

• dfg/DFGNode.h:

(JSC::DFG::Node::containsMovHint):
(JSC::DFG::Node::accessesStack):
(JSC::DFG::Node::hasLocal): Deleted.

• dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

• dfg/DFGValidate.cpp:

File:

• trunk/Source/JavaScriptCore/dfg/DFGMaximalFlushInsertionPhase.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGMaximalFlushInsertionPhase.cpp

@@ -79 +79 @@
                 }
 
-                if (node->hasVariableAccessData(m_graph))
+                if (node->accessesStack(m_graph))
                     currentBlockAccessData.operand(node->local()) = node->variableAccessData();
             }
@@ -111 +111 @@
         for (unsigned i = 0; i < block->size(); i++) {
             Node* node = block->at(i);
-            if (!node->hasVariableAccessData(m_graph))
+            if (!node->accessesStack(m_graph))
                 continue;