Changeset 203923 in webkit for trunk/Source/JavaScriptCore/dfg/DFGPredictionInjectionPhase.cpp

Timestamp:

Jul 29, 2016, 3:04:02 PM (9 years ago)

Author:

[email protected]

Message:

Refactor DFG::Node::hasLocal() to accessesStack()
​https://bugs.webkit.org/show_bug.cgi?id=160357

Reviewed by Filip Pizlo.

Refactoring in preparation for using register arguments for JavaScript calls.

Renamed Node::hasLocal() to Node::accessesStack() and changed all uses accordingly.
Also changed uses of Node::hasVariableAccessData() to accessesStack() where that
use guards stack operation logic associated with the Node's VariableAccessData.

The hasVariableAccessData() check now implies no more than the node has a
VariableAccessData and nothing about its use of that data to coordinate stack
accesses.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

• dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock):

• dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):

• dfg/DFGNode.h:

(JSC::DFG::Node::containsMovHint):
(JSC::DFG::Node::accessesStack):
(JSC::DFG::Node::hasLocal): Deleted.

• dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

• dfg/DFGValidate.cpp:

File:

• trunk/Source/JavaScriptCore/dfg/DFGPredictionInjectionPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGPredictionInjectionPhase.cpp

@@ -75 +75 @@
                 if (!node)
                     continue;
-                ASSERT(node->hasLocal(m_graph));
+                ASSERT(node->accessesStack(m_graph));
                 node->variableAccessData()->predict(
                     speculationFromValue(m_graph.m_plan.mustHandleValues[i]));