Changeset 204352 in webkit for trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp

Timestamp:

Aug 10, 2016, 2:19:03 PM (9 years ago)

Author:

[email protected]

Message:

[JSC] Remove some useless code I left when rewriting CSE's large maps
​https://bugs.webkit.org/show_bug.cgi?id=160720

Patch by Benjamin Poulain <​[email protected]> on 2016-08-10
Reviewed by Michael Saboff.

• dfg/DFGCSEPhase.cpp:

The maps m_worldMap && m_sideStateMap are useless. They come from the previous
iteration that had weaker constraints.

Also move m_heapMap after m_fallbackStackMap since that is the order
in which they are used in the algorithm.

File:

• trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp

@@ -109 +109 @@
     ImpureMap(ImpureMap&& other)
     {
-        m_heapMap.swap(other.m_heapMap);
         m_abstractHeapStackMap.swap(other.m_abstractHeapStackMap);
         m_fallbackStackMap.swap(other.m_fallbackStackMap);
+        m_heapMap.swap(other.m_heapMap);
 #if !defined(NDEBUG)
         m_debugImpureData.swap(other.m_debugImpureData);
@@ -176 +176 @@
     void clear()
     {
-        m_heapMap.clear();
         m_abstractHeapStackMap.clear();
         m_fallbackStackMap.clear();
+        m_heapMap.clear();
 #if !defined(NDEBUG)
         m_debugImpureData.clear();
@@ -258 +258 @@
     }
 
-    Map m_worldMap;
-    Map m_heapMap;
-    Map m_sideStateMap;
-
     // The majority of Impure Stack Slotsare unique per value.
     // This is very useful for fast clobber(), we can just remove the slot addressed by AbstractHeap
@@ -275 +271 @@
     HashMap<int32_t, std::unique_ptr<ImpureDataSlot>, DefaultHash<int32_t>::Hash, WTF::SignedWithZeroKeyHashTraits<int32_t>> m_abstractHeapStackMap;
     Map m_fallbackStackMap;
+
+    Map m_heapMap;
 
 #if !defined(NDEBUG)