Changeset 205131 in webkit for trunk/Source/JavaScriptCore/runtime/JSSet.cpp

Timestamp:

Aug 29, 2016, 11:50:44 AM (9 years ago)

Author:

[email protected]

Message:

Fix toStringName for Proxies and add support for normal instances
​https://bugs.webkit.org/show_bug.cgi?id=161275

Reviewed by Saam Barati.

toStringName on proxies needs to follow the chain of proxies until it finds a non-proxy target.
Additionally, there are a couple of other classes that need to return "Object" for their
toStringName. Since this isn't tested by test262 I will propose a new test there.

• runtime/ClassInfo.h:
• runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::toStringName):

• runtime/JSArrayBufferView.h:
• runtime/JSCell.cpp:

(JSC::JSCell::toStringName):

• runtime/JSCell.h:
• runtime/JSMap.cpp:

(JSC::JSMap::toStringName):

• runtime/JSMap.h:
• runtime/JSObject.cpp:

(JSC::JSObject::toStringName):

• runtime/JSObject.h:
• runtime/JSSet.cpp:

(JSC::JSSet::destroy):
(JSC::JSSet::toStringName):

• runtime/JSSet.h:
• runtime/JSWeakMap.cpp:

(JSC::JSWeakMap::toStringName):

• runtime/JSWeakMap.h:
• runtime/JSWeakSet.cpp:

(JSC::JSWeakSet::toStringName):

• runtime/JSWeakSet.h:
• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::toStringName):

• runtime/ProxyObject.h:
• runtime/SymbolObject.cpp:

(JSC::SymbolObject::toStringName):

• runtime/SymbolObject.h:

(JSC::SymbolObject::internalValue):

File:

• trunk/Source/JavaScriptCore/runtime/JSSet.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSSet.cpp

@@ -42 +42 @@
     JSSet* thisObject = jsCast<JSSet*>(cell);
     thisObject->JSSet::~JSSet();
+}
+
+String JSSet::toStringName(const JSObject*, ExecState*)
+{
+    return ASCIILiteral("Object");
 }