Changeset 20569 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Mar 28, 2007, 11:20:38 PM (18 years ago)

Author:

dsmith

Message:

JavaScriptCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

• holes in arrays should be skipped, not treated as undefined, by all such methods
• an element with value undefined is not a hole
• Array.prototype.forEach should return undefined

• kjs/array_object.cpp: (ArrayInstance::getOwnPropertySlot): (ArrayProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

• holes in arrays should be skipped, not treated as undefined, by all such methods
• an element with value undefined is not a hole
• Array.prototype.forEach should return undefined

• fast/js/array-every-expected.txt:
• fast/js/array-filter-expected.txt: Added.
• fast/js/array-filter.html: Added.
• fast/js/array-foreach-expected.txt:
• fast/js/array-foreach.html:
• fast/js/array-indexof-expected.txt:
• fast/js/array-indexof.html:
• fast/js/array-lastIndexOf-expected.txt:
• fast/js/array-map-expected.txt: Added.
• fast/js/array-map.html: Added.
• fast/js/array-some-expected.txt:
• fast/js/array-some.html:
• fast/js/resources/array-every.js:
• fast/js/resources/array-lastIndexOf.js:

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (6 diffs)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -102 +102 @@
     if (index < storageLength) {
       JSValue *v = storage[index];
-      if (!v || v->isUndefined())
+      if (!v)
         return false;      
       slot.setValueSlot(this, &storage[index]);
@@ -121 +121 @@
   if (index < storageLength) {
     JSValue *v = storage[index];
-    if (!v || v->isUndefined())
+    if (!v)
       return false;
     slot.setValueSlot(this, &storage[index]);
@@ -790 +790 @@
     if (id == Filter) 
       resultArray = static_cast<JSObject *>(exec->lexicalInterpreter()->builtinArray()->construct(exec, List::empty()));
-    else
- {
+    else {
       List args;
       args.append(jsNumber(length));
@@ -840 +839 @@
       result = jsBoolean(id == Every);
     else
-      result = thisObj;
+      result = jsUndefined();
     
     for (unsigned k = 0; k < length && !exec->hadException(); ++k) {
@@ -887 +886 @@
         JSValue* e = getProperty(exec, thisObj, index);
         if (!e)
-            e = jsUndefined();
+            continue;
         if (strictEqual(exec, searchElement, e))
             return jsNumber(index);
@@ -913 +912 @@
         JSValue* e = getProperty(exec, thisObj, index);
         if (!e)
-            e = jsUndefined();
+            continue;
         if (strictEqual(exec, searchElement, e))
             return jsNumber(index);