Changeset 207542 in webkit for trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h

Timestamp:

Oct 19, 2016, 10:18:27 AM (9 years ago)

Author:

[email protected]

Message:

[Xcode] JavaScriptCore fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
​https://bugs.webkit.org/show_bug.cgi?id=163642

Reviewed by Darin Adler.

• API/JSClassRef.cpp: Removed a bad headerdoc comment inside an implementation file.
• API/JSContext.h: Changed @methodgroup to @functiongroup, because the compiler requires the former to be followed by a method (and we have a property), but not the latter. Changed a couple of instances of “method” to “@method”. Removed empty @param entries.
• API/JSContextRefInternal.h: Named a parameter referenced in a @param entry.
• API/JSContextRefPrivate.h: Ditto.
• API/JSManagedValue.h: Removed empty @param entries.
• API/JSObjectRef.h: Corrected parameter name in @param entry.
• API/JSTypedArray.h: Ditto.
• API/JSValue.h: Removed empty @param entries, changed @methodgroup to @functiongroup, and changed @method to @property where appropriate. Removed empty @param entries.
• API/JSValueRef.h: Named a parameter referenced in a @param entry.
• API/JSWeakObjectMapRefPrivate.h: Ditto.
• Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS. Made the compiler treat the icu headers as system headers, to stop it from emitting warnings about headers we don’t want to change.
• Configurations/ToolExecutable.xcconfig: Made the compiler treat the icu headers as system headers.

File:

• trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h

@@ -65 +65 @@
  @param object The user defined object to associate with the key.
  */
-JS_EXPORT void JSWeakObjectMapSet(JSContextRef ctx, JSWeakObjectMapRef map, void* key, JSObjectRef);
+JS_EXPORT void JSWeakObjectMapSet(JSContextRef ctx, JSWeakObjectMapRef map, void* key, JSObjectRef object);
 
 /*!