Changeset 207842 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Oct 25, 2016, 1:33:46 PM (9 years ago)

Author:

[email protected]

Message:

jsc.cpp is leaking memory allocated by readline in runInteractive
​https://bugs.webkit.org/show_bug.cgi?id=163958

According to ​http://web.mit.edu/gnu/doc/html/rlman_2.html,
"The line readline returns is allocated with malloc ();
you should free () the line when you are done with it."
The memory allocated by readline is not being freed when it should.

Patch by Christopher Reid <​[email protected]> on 2016-10-25
Reviewed by Mark Lam.

• jsc.cpp:

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -2630 +2630 @@
             source = source + '\n';
             checkSyntax(globalObject->vm(), makeSource(source, interpreterName), error);
-            if (!line[0])
+            if (!line[0]) {
+                free(line);
                 break;
+            }
             add_history(line);
+            free(line);
         } while (error.syntaxErrorType() == ParserError::SyntaxErrorRecoverable);