Changeset 208078 in webkit for trunk/Source/JavaScriptCore/dfg/DFGGraph.cpp

Timestamp:

Oct 28, 2016, 4:19:06 PM (9 years ago)

Author:

Yusuke Suzuki

Message:

[DOMJIT] Include identifier name in CallDOMGetter to dump it
​https://bugs.webkit.org/show_bug.cgi?id=164161

Reviewed by Mark Lam.

This patch adds an identifier number to CallDOMGetterData and use it when dumping the data.
CallDOMGetter did not include identifier. It made CallDOMGetter super hard to debug when dumping DFG graph.

The dump becomes like this.

CallDOMGetter(Cell:@21, JS|MustGen|UseAsOther, Nonboolint32, id0{customGetter}, domJIT = 0x42f8a0, R:World, W:Heap, Exits, ClobbersExit, bc#15) predicting Nonboolint32

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::ByteCodeParser::handleGetById):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGNode.h:

File:

• trunk/Source/JavaScriptCore/dfg/DFGGraph.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGGraph.cpp

@@ -348 +348 @@
         out.print(", offset = ", data->offset, ", mandatoryMinimum = ", data->mandatoryMinimum);
         out.print(", limit = ", data->limit);
+    }
+    if (node->hasCallDOMGetterData()) {
+        CallDOMGetterData* data = node->callDOMGetterData();
+        out.print(comma, "id", data->identifierNumber, "{", identifiers()[data->identifierNumber], "}");
+        out.print(", domJIT = ", RawPointer(data->domJIT));
     }
     if (node->isConstant())