Changeset 208224 in webkit for trunk/Source/JavaScriptCore/dfg/DFGNode.h

Timestamp:

Nov 1, 2016, 10:20:25 AM (9 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r208208 and r208210.
​https://bugs.webkit.org/show_bug.cgi?id=164276

This change caused 28 JSC test failures. (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"We should be able to eliminate rest parameter allocations"
​https://bugs.webkit.org/show_bug.cgi?id=163925
​http://trac.webkit.org/changeset/208208

"Fix the EFL build."
​http://trac.webkit.org/changeset/208210

File:

• trunk/Source/JavaScriptCore/dfg/DFGNode.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/dfg/DFGNode.h

@@ -459 +459 @@
         case PhantomDirectArguments:
         case PhantomClonedArguments:
-        case PhantomCreateRest:
             // These pretend to be the empty value constant for the benefit of the DFG backend, which
             // otherwise wouldn't take kindly to a node that doesn't compute a value.
@@ -473 +472 @@
         ASSERT(hasConstant());
         
-        if (op() == PhantomDirectArguments || op() == PhantomClonedArguments || op() == PhantomCreateRest) {
+        if (op() == PhantomDirectArguments || op() == PhantomClonedArguments) {
             // These pretend to be the empty value constant for the benefit of the DFG backend, which
             // otherwise wouldn't take kindly to a node that doesn't compute a value.
@@ -1747 +1746 @@
         case PhantomNewObject:
         case PhantomDirectArguments:
-        case PhantomCreateRest:
         case PhantomClonedArguments:
         case PhantomNewFunction:
@@ -2391 +2389 @@
     unsigned numberOfArgumentsToSkip()
     {
-        ASSERT(op() == CreateRest || op() == GetRestLength || op() == GetMyArgumentByVal || op() == GetMyArgumentByValOutOfBounds);
+        ASSERT(op() == CreateRest || op() == GetRestLength);
         return m_opInfo.as<unsigned>();
     }