Changeset 208588 in webkit for trunk/Source/JavaScriptCore/dfg/DFGArrayMode.cpp

Timestamp:

Nov 11, 2016, 8:50:57 AM (9 years ago)

Author:

Chris Dumez

Message:

Unreviewed, rolling out r208117 and r208160.

Regressed Speedometer by >1.5%

Reverted changesets:

"We should have a way of profiling when a get_by_id is pure
and to emit a PureGetById in the DFG/FTL"
​https://bugs.webkit.org/show_bug.cgi?id=163305
​http://trac.webkit.org/changeset/208117

"Debug JSC test microbenchmarks/pure-get-by-id-cse-2.js timing
out"
​https://bugs.webkit.org/show_bug.cgi?id=164227
​http://trac.webkit.org/changeset/208160

File:

• trunk/Source/JavaScriptCore/dfg/DFGArrayMode.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGArrayMode.cpp

@@ -153 +153 @@
 static bool canBecomeGetArrayLength(Graph& graph, Node* node)
 {
-    if (node->op() == GetById || node->op() == PureGetById) {
-        auto uid = graph.identifiers()[node->identifierNumber()];
-        return uid == graph.m_vm.propertyNames->length.impl();
-    }
-    return false;
+    if (node->op() != GetById)
+        return false;
+    auto uid = graph.identifiers()[node->identifierNumber()];
+    return uid == graph.m_vm.propertyNames->length.impl();
 }