Changeset 208592 in webkit for trunk/Source/JavaScriptCore/dfg/DFGGraph.h

Timestamp:

Nov 11, 2016, 10:21:20 AM (9 years ago)

Author:

Chris Dumez

Message:

Unreviewed, rolling out r208584.

Seems to have regressed Speedometer by 1% on Mac

Reverted changeset:

"We should have a more concise way of determining when we're
varargs calling a function using rest parameters"
​https://bugs.webkit.org/show_bug.cgi?id=164258
​http://trac.webkit.org/changeset/208584

File:

• trunk/Source/JavaScriptCore/dfg/DFGGraph.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGGraph.h

@@ -666 +666 @@
         return watchpoints().isWatched(globalObject->havingABadTimeWatchpoint());
     }
-
-    bool isWatchingArrayIteratorProtocolWatchpoint(Node* node)
-    {
-        JSGlobalObject* globalObject = globalObjectFor(node->origin.semantic);
-        InlineWatchpointSet& set = globalObject->arrayIteratorProtocolWatchpoint();
-        if (watchpoints().isWatched(set))
-            return true;
-
-        if (set.isStillValid()) {
-            // Since the global object owns this watchpoint, we make ourselves have a weak pointer to it.
-            // If the global object got deallocated, it wouldn't fire the watchpoint. It's unlikely the
-            // global object would get deallocated without this code ever getting thrown away, however,
-            // it's more sound logically to depend on the global object lifetime weakly.
-            freeze(globalObject);
-            watchpoints().addLazily(set);
-            return true;
-        }
-
-        return false;
-    }
     
     Profiler::Compilation* compilation() { return m_plan.compilation.get(); }
@@ -924 +904 @@
     Bag<LazyJSValue> m_lazyJSValues;
     Bag<CallDOMGetterData> m_callDOMGetterData;
-    Bag<BitVector> m_bitVectors;
     Vector<InlineVariableData, 4> m_inlineVariableData;
     HashMap<CodeBlock*, std::unique_ptr<FullBytecodeLiveness>> m_bytecodeLiveness;