Changeset 209642 in webkit for trunk/Source/JavaScriptCore/wasm/WasmModuleParser.cpp

Timestamp:

Dec 9, 2016, 6:34:02 PM (9 years ago)

Author:

[email protected]

Message:

WebAssembly JS API: implement start function
​https://bugs.webkit.org/show_bug.cgi?id=165150

Reviewed by Saam Barati.

JSTests:

• wasm/Builder.js: allow building a .Start()
• wasm/Builder_WebAssemblyBinary.js:
• wasm/js-api/test_Start.js: Added.

(const.emitters.Start): serialize a start section

• wasm/self-test/test_BuilderJSON.js: validate the start section's content

Source/JavaScriptCore:

• wasm/WasmFormat.h: pass the start function around
• wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseTable): mark unreachable code
(JSC::Wasm::ModuleParser::parseGlobal): mark unreachable code
(JSC::Wasm::ModuleParser::parseStart): mark unreachable code
(JSC::Wasm::ModuleParser::parseElement): mark unreachable code
(JSC::Wasm::ModuleParser::parseData): mark unreachable code

• wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction): NFC: call the new function below
(JSC::WebAssemblyFunction::call): separate this out so that the start function can use it

• wasm/js/WebAssemblyFunction.h:
• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::visitChildren): visit the start function
(JSC::WebAssemblyModuleRecord::link): handle start function
(JSC::WebAssemblyModuleRecord::evaluate): call the start function, if present

• wasm/js/WebAssemblyModuleRecord.h:

File:

• trunk/Source/JavaScriptCore/wasm/WasmModuleParser.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/wasm/WasmModuleParser.cpp

@@ -304 +304 @@
 bool ModuleParser::parseTable()
 {
-    // FIXME
+    // FIXME implement table https://bugs.webkit.org/show_bug.cgi?id=164135
+    RELEASE_ASSERT_NOT_REACHED();
     return true;
 }
@@ -366 +367 @@
 {
     // FIXME https://bugs.webkit.org/show_bug.cgi?id=164133
+    RELEASE_ASSERT_NOT_REACHED();
     return true;
 }
@@ -416 +418 @@
 bool ModuleParser::parseStart()
 {
+    uint32_t startFunctionIndex;
+    if (!parseVarUInt32(startFunctionIndex)
+        || startFunctionIndex >= m_functionIndexSpace.size())
+        return false;
+    Signature* signature = m_functionIndexSpace[startFunctionIndex].signature;
+    if (signature->arguments.size() != 0
+        || signature->returnType != Void)
+        return false;
+    m_module->startFunctionIndexSpace = startFunctionIndex;
+    return true;
+}
+
+bool ModuleParser::parseElement()
+{
     // FIXME https://bugs.webkit.org/show_bug.cgi?id=161709
-    return true;
-}
-
-bool ModuleParser::parseElement()
-{
-    // FIXME https://bugs.webkit.org/show_bug.cgi?id=161709
+    RELEASE_ASSERT_NOT_REACHED();
     return true;
 }
@@ -451 +462 @@
 {
     // FIXME https://bugs.webkit.org/show_bug.cgi?id=161709
+    RELEASE_ASSERT_NOT_REACHED();
     return true;
 }