Changeset 209650 in webkit for trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

Timestamp:

Dec 9, 2016, 10:04:28 PM (9 years ago)

Author:

[email protected]

Message:

It is okay to turn undefined into null because we are producing values for a
JSON representation (InspectorValue) and JSON has a null value and no
undefined value.
​https://bugs.webkit.org/show_bug.cgi?id=165506

Patch by Karim H <​[email protected]> on 2016-12-09
Reviewed by Darin Adler.

• bindings/ScriptValue.cpp:

(Inspector::jsToInspectorValue):

File:

• trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bindings/ScriptValue.cpp

@@ -54 +54 @@
 
     if (value.isUndefinedOrNull())
-        return InspectorValue::null(); // FIXME: Why is it OK to turn undefined into null?
+        return InspectorValue::null();
     if (value.isBoolean())
         return InspectorValue::create(value.asBoolean());