Changeset 209678 in webkit for trunk/Source/JavaScriptCore/dfg/DFGMinifiedNode.h

Timestamp:

Dec 10, 2016, 5:14:37 PM (9 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r209653, r209654, r209663, and
r209673.
​https://bugs.webkit.org/show_bug.cgi?id=165739

speedometer crashes (Requested by pizlo on #webkit).

Reverted changesets:

"JSVALUE64: Pass arguments in platform argument registers when
making JavaScript calls"
​https://bugs.webkit.org/show_bug.cgi?id=160355
​http://trac.webkit.org/changeset/209653

"Unreviewed build fix for 32 bit builds."
​http://trac.webkit.org/changeset/209654

"Unreviewed build fix for the CLOOP after r209653"
​http://trac.webkit.org/changeset/209663

"REGRESSION(r209653) Crash in CallFrameShuffler::snapshot()"
​https://bugs.webkit.org/show_bug.cgi?id=165728
​http://trac.webkit.org/changeset/209673

File:

• trunk/Source/JavaScriptCore/dfg/DFGMinifiedNode.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/dfg/DFGMinifiedNode.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2012, 2014-2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2014, 2015 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -44 +44 @@
     case PhantomDirectArguments:
     case PhantomClonedArguments:
-    case GetArgumentRegister:
         return true;
     default:
@@ -73 +72 @@
         return bitwise_cast<InlineCallFrame*>(static_cast<uintptr_t>(m_info));
     }
-
-    bool hasArgumentIndex() const { return hasArgumentIndex(m_op); }
-
-    unsigned argumentIndex() const { return static_cast<unsigned>(m_info); }
     
     static MinifiedID getID(MinifiedNode* node) { return node->id(); }
@@ -94 +89 @@
         return type == PhantomDirectArguments || type == PhantomClonedArguments;
     }
-
-    static bool hasArgumentIndex(NodeType type)
-    {
-        return type == GetArgumentRegister;
-    }
     
     MinifiedID m_id;