Get rid of HeapRootVisitor and make SlotVisitor less painful to use
https://bugs.webkit.org/show_bug.cgi?id=165911
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Previously we had two ways of adding a raw pointer to the GC's mark stack:
- SlotVisitor::appendUnbarrieredXYZ() methods
- HeapRootVisitor::visit() methods
HeapRootVisitor existed only to prevent you from calling its non-WriteBarrier<> methods
unless you had permission. But SlotVisitor would let you do it anyway, because that was
a lot more practical.
I think that we should just have one way to do it. This removes HeapRootVisitor. It
also renames appendUnbarrieredXYZ to appendUnbarriered, and it removes the use of extra
indirection (so you now pass const WriteBarrier<>& instead of WriteBarrier<>*).
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/builtins/builtins_templates.py:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitWeakly):
(JSC::CodeBlock::visitChildren):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::visitOSRExitTargets):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::stronglyVisitWeakReferences):
- bytecode/DirectEvalCodeCache.cpp:
(JSC::DirectEvalCodeCache::visitAggregate):
- bytecode/InternalFunctionAllocationProfile.h:
(JSC::InternalFunctionAllocationProfile::visitAggregate):
- bytecode/ObjectAllocationProfile.h:
(JSC::ObjectAllocationProfile::visitAggregate):
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::propagateTransitions):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::visitChildren):
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::visitChildren):
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::visitChildren):
- dfg/DFGDesiredTransitions.cpp:
(JSC::DFG::DesiredTransition::visitChildren):
- dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::visitChildren):
(JSC::DFG::Graph::visitChildren):
(JSC::DFG::Plan::markCodeBlocks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::HandleSet::visitStrongHandles):
- heap/HandleSet.h:
- heap/HandleStack.cpp:
(JSC::HandleStack::visit):
- heap/HandleStack.h:
- heap/Heap.cpp:
(JSC::Heap::markToFixpoint):
- heap/Heap.h:
- heap/HeapRootVisitor.h: Removed.
- heap/LargeAllocation.cpp:
(JSC::LargeAllocation::visitWeakSet):
- heap/LargeAllocation.h:
- heap/MarkedBlock.h:
(JSC::MarkedBlock::Handle::visitWeakSet):
(JSC::MarkedSpace::visitWeakSets):
- heap/MarkedSpace.h:
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::appendUnbarriered):
- heap/SlotVisitor.h:
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::appendUnbarriered):
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendHidden):
(JSC::SlotVisitor::appendValues):
(JSC::SlotVisitor::appendValuesHidden):
(JSC::SlotVisitor::appendUnbarrieredPointer): Deleted.
(JSC::SlotVisitor::appendUnbarrieredReadOnlyPointer): Deleted.
(JSC::SlotVisitor::appendUnbarrieredValue): Deleted.
(JSC::SlotVisitor::appendUnbarrieredReadOnlyValue): Deleted.
(JSC::SlotVisitor::appendUnbarrieredWeak): Deleted.
(JSC::WeakBlock::specializedVisit):
(JSC::WeakBlock::visit):
- heap/WeakBlock.h:
- heap/WeakSet.h:
(JSC::WeakSet::visit):
- interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::visitChildren):
- jit/GCAwareJITStubRoutine.cpp:
(JSC::MarkingGCAwareJITStubRoutine::markRequiredObjectsInternal):
- jit/PolymorphicCallStubRoutine.cpp:
(JSC::PolymorphicCallStubRoutine::markRequiredObjectsInternal):
(WTF::Element::visitChildren):
(WTF::ImpureGetter::visitChildren):
(WTF::SimpleObject::visitChildren):
- runtime/AbstractModuleRecord.cpp:
(JSC::AbstractModuleRecord::visitChildren):
(JSC::MarkedArgumentBuffer::markLists):
- runtime/ArgList.h:
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::visitChildren):
- runtime/DirectArguments.cpp:
(JSC::DirectArguments::visitChildren):
- runtime/EvalExecutable.cpp:
(JSC::EvalExecutable::visitChildren):
(JSC::Exception::visitChildren):
- runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::visitChildren):
- runtime/FunctionRareData.cpp:
(JSC::FunctionRareData::visitChildren):
- runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
(JSC::HashMapBucket<Data>::visitChildren):
(JSC::HashMapImpl<HashMapBucket>::visitChildren):
- runtime/InferredTypeTable.cpp:
(JSC::InferredTypeTable::visitChildren):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::visitChildren):
- runtime/IntlCollator.cpp:
(JSC::IntlCollator::visitChildren):
- runtime/IntlCollatorConstructor.cpp:
(JSC::IntlCollatorConstructor::visitChildren):
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::visitChildren):
- runtime/IntlDateTimeFormatConstructor.cpp:
(JSC::IntlDateTimeFormatConstructor::visitChildren):
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::visitChildren):
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::IntlNumberFormatConstructor::visitChildren):
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::visitChildren):
(JSC::JSCallee::visitChildren):
(JSC::JSCell::visitChildren):
- runtime/JSCustomGetterSetterFunction.cpp:
(JSC::JSCustomGetterSetterFunction::visitChildren):
(JSC::JSFunction::visitChildren):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
- runtime/JSMapIterator.cpp:
(JSC::JSMapIterator::visitChildren):
- runtime/JSModuleEnvironment.cpp:
(JSC::JSModuleEnvironment::visitChildren):
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::visitChildren):
- runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::visitChildren):
- runtime/JSNativeStdFunction.cpp:
(JSC::JSNativeStdFunction::visitChildren):
(JSC::JSObject::visitButterflyImpl):
- runtime/JSPromiseDeferred.cpp:
(JSC::JSPromiseDeferred::visitChildren):
- runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::visitChildren):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
(JSC::JSProxy::visitChildren):
(JSC::JSScope::visitChildren):
- runtime/JSSegmentedVariableObject.cpp:
(JSC::JSSegmentedVariableObject::visitChildren):
- runtime/JSSetIterator.cpp:
(JSC::JSSetIterator::visitChildren):
(JSC::JSRopeString::visitFibers):
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::visitChildren):
(JSC::JSWeakMap::visitChildren):
(JSC::JSWeakSet::visitChildren):
(JSC::JSWithScope::visitChildren):
- runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
- runtime/LazyClassStructure.cpp:
(JSC::LazyClassStructure::visit):
- runtime/LazyPropertyInlines.h:
(JSC::ElementType>::visit):
(JSC::MapBase<HashMapBucketType>::visitChildren):
- runtime/ModuleProgramExecutable.cpp:
(JSC::ModuleProgramExecutable::visitChildren):
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
- runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::visitChildren):
(JSC::ProxyObject::visitChildren):
(JSC::ProxyRevoke::visitChildren):
- runtime/RegExpCachedResult.cpp:
(JSC::RegExpCachedResult::visitChildren):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::visitChildren):
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::visit):
- runtime/ScopedArguments.cpp:
(JSC::ScopedArguments::visitChildren):
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::visitStrongReferences):
- runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::visitChildren):
(JSC::Structure::visitChildren):
(JSC::Structure::markIfCheap):
- runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::visitChildren):
(JSC::SymbolTable::visitChildren):
- runtime/TypeProfilerLog.cpp:
(JSC::TypeProfilerLog::visit):
(JSC::WeakMapData::DeadKeyCleaner::visitWeakReferences):
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::visitChildren):
- wasm/js/JSWebAssemblyMemory.cpp:
(JSC::JSWebAssemblyMemory::visitChildren):
- wasm/js/JSWebAssemblyModule.cpp:
(JSC::JSWebAssemblyModule::visitChildren):
- wasm/js/JSWebAssemblyTable.cpp:
(JSC::JSWebAssemblyTable::visitChildren):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::visitChildren):
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::visitChildren):
Source/WebCore:
No new tests because no new behavior.
This updates WebCore code to new JSC API.
- bindings/js/JSDOMBinding.cpp:
(WebCore::DOMConstructorJSBuiltinObject::visitChildren):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/js/JSDOMPromise.h:
(WebCore::DeferredPromise::visitAggregate):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::visitJSFunction):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::visitChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
