Changeset 210023 in webkit for trunk/Source/JavaScriptCore/dfg/DFGLICMPhase.cpp

Timestamp:

Dec 20, 2016, 10:26:10 AM (8 years ago)

Author:

Konstantin Tokarev

Message:

Modernize for loops in JSC
​https://bugs.webkit.org/show_bug.cgi?id=166060

Reviewed by Yusuke Suzuki.

• API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::getArrayProfile):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::nameForRegister):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):

• bytecompiler/NodesCodegen.cpp:

(JSC::ObjectPatternNode::bindValue):

• debugger/Debugger.cpp:

(JSC::Debugger::applyBreakpoints):

• dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):

• dfg/DFGClobberSet.cpp:

(JSC::DFG::ClobberSet::setOf):

• dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::reallyAdd):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::visitChildren):

• dfg/DFGIntegerCheckCombiningPhase.cpp:

(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):

• dfg/DFGIntegerRangeOptimizationPhase.cpp:
• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):

• dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):

• dfg/DFGPutStackSinkingPhase.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::linkBranches):

• dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run):

• dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

• dfg/DFGValidate.cpp:
• dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

• heap/HeapVerifier.cpp:

(JSC::trimDeadObjectsFromList):
(JSC::HeapVerifier::trimDeadObjects):

• heap/LiveObjectList.cpp:

(JSC::LiveObjectList::findObject):

• heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::isPagedOut):

• inspector/ScriptCallStack.cpp:

(Inspector::ScriptCallStack::firstNonNativeCallFrame):

• jit/JIT.cpp:

(JSC::JIT::link):

• parser/VariableEnvironment.cpp:

(JSC::VariableEnvironment::markAllVariablesAsCaptured):
(JSC::VariableEnvironment::hasCapturedVariables):

• runtime/FunctionHasExecutedCache.cpp:

(JSC::FunctionHasExecutedCache::hasExecutedAtOffset):
(JSC::FunctionHasExecutedCache::getFunctionRanges):

• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::visitChildren):

• runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::findLocation):

• runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::dumpTypes):

• runtime/VM.cpp:

(JSC::VM::gatherConservativeRoots):

• runtime/WeakMapData.cpp:

(JSC::WeakMapData::DeadKeyCleaner::visitWeakReferences):
(JSC::WeakMapData::DeadKeyCleaner::finalizeUnconditionally):

• tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::dumpInternal):

• yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

File:

• trunk/Source/JavaScriptCore/dfg/DFGLICMPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGLICMPhase.cpp

@@ -103 +103 @@
                 continue;
             LoopData& data = m_data[loop->index()];
-            for (unsigned nodeIndex = 0; nodeIndex < block->size(); ++nodeIndex) {
-                Node* node = block->at(nodeIndex);
-                
+            for (auto* node : *block) {
                 // Don't look beyond parts of the code that definitely always exit.
                 // FIXME: This shouldn't be needed.