Changeset 21018 in webkit for trunk/JavaScriptCore/kjs/collector.cpp

Timestamp:

Apr 22, 2007, 9:10:47 PM (18 years ago)

Author:

mjs

Message:

Reviewed by Darin.

• shrink PropertyMap by 8 bytes and therefore shrink CELL_SIZE to 40 (for 32-bit; similar shrinkage for 64-bit) ​http://bugs.webkit.org/show_bug.cgi?id=13384

Inspired by similar changes by Christopher E. Hyde <​[email protected]>
done in the kjs-tweaks branch of KDE's kjs. However, this version is somewhat
cleaner style-wise and avoids some of the negative speed impact (at least on gcc/x86)
of his version.

This is nearly a wash performance-wise, maybe a slight slowdown, but worth doing
to eventually reach cell size 32.

• kjs/collector.cpp: (KJS::):
• kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::expand): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::checkConsistency):
• kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): (KJS::PropertyMap::setHasGetterSetterProperties): (KJS::PropertyMap::): (KJS::PropertyMap::PropertyMap):

File:

• trunk/JavaScriptCore/kjs/collector.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/collector.cpp

@@ -69 +69 @@
 
 template<size_t bytesPerWord> struct CellSize;
-template<> struct CellSize<sizeof(uint32_t)> { static const size_t m_value = 48; }; // 32-bit
-template<> struct CellSize<sizeof(uint64_t)> { static const size_t m_value = 80; }; // 64-bit
+template<> struct CellSize<sizeof(uint32_t)> { static const size_t m_value = 40; }; // 32-bit
+template<> struct CellSize<sizeof(uint64_t)> { static const size_t m_value = 64; }; // 64-bit
 
 const size_t BLOCK_SIZE = (16 * 4096); // 64k