Changeset 21032 in webkit for trunk/JavaScriptCore/kjs/function.h

Timestamp:

Apr 23, 2007, 3:28:10 AM (18 years ago)

Author:

mjs

Message:

Reviewed by Darin.

• shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

I reconciled this with a similar change in KDE kjs by Maks Orlovich <​[email protected]>.

• kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
• kjs/function.h:
• kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
• kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
• kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because they handle size_t badly.

File:

• trunk/JavaScriptCore/kjs/function.h (modified) (4 diffs)

trunk/JavaScriptCore/kjs/function.h

@@ -33 +33 @@
   class ActivationImp;
   class FunctionBodyNode;
-  class Parameter;
 
   /**
@@ -50 +49 @@
     virtual JSValue* callAsFunction(ExecState*, JSObject* thisObj, const List& args);
 
-    void addParameter(const Identifier& n);
+    // Note: unlike body->paramName, this returns Identifier::null for parameters 
+    // that will never get set, due to later param having the same name
     Identifier getParameterName(int index);
-    // parameters in string representation, e.g. (a, b, c)
-    UString parameterString() const;
     virtual CodeType codeType() const = 0;
 
@@ -93 +91 @@
 
     virtual void mark();
-  protected:
-    OwnPtr<Vector<Parameter> > parameters;
 
   private:
@@ -103 +99 @@
     static JSValue* lengthGetter(ExecState*, JSObject*, const Identifier&, const PropertySlot&);
 
-    void processParameters(ExecState*, const List&);
+    void passInParameters(ExecState*, const List&);
     virtual void processVarDecls(ExecState*);
   };