Changeset 21032 in webkit for trunk/JavaScriptCore/kjs/function_object.cpp

Timestamp:

Apr 23, 2007, 3:28:10 AM (18 years ago)

Author:

mjs

Message:

Reviewed by Darin.

• shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

I reconciled this with a similar change in KDE kjs by Maks Orlovich <​[email protected]>.

• kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
• kjs/function.h:
• kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
• kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
• kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because they handle size_t badly.

File:

• trunk/JavaScriptCore/kjs/function_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/function_object.cpp

@@ -84 +84 @@
         DeclaredFunctionImp *fi = static_cast<DeclaredFunctionImp*>(thisObj);
         return jsString("function " + fi->functionName().ustring() + "(" +
-                        fi->parameterString() + ") " + fi->body->toString());
+                        fi->body->paramString() + ") " + fi->body->toString());
      } else if (thisObj->inherits(&InternalFunctionImp::info) &&
                 !static_cast<InternalFunctionImp*>(thisObj)->functionName().isNull()) {
@@ -229 +229 @@
               c++, i++;
           if (i == len) {
-              fimp->addParameter(Identifier(param));
+              bodyNode->addParam(Identifier(param));
               params++;
               break;
           } else if (*c == ',') {
-              fimp->addParameter(Identifier(param));
+              bodyNode->addParam(Identifier(param));
               params++;
               c++, i++;