Changeset 210458 in webkit for trunk/Source/JavaScriptCore/API/JSVirtualMachineInternal.h

Timestamp:

Jan 6, 2017, 3:38:31 PM (8 years ago)

Author:

[email protected]

Message:

The ObjC API's JSVirtualMachine's map tables need to be guarded by a lock.
​https://bugs.webkit.org/show_bug.cgi?id=166778
<rdar://problem/29761198>

Reviewed by Filip Pizlo.

Now that we have a concurrent GC, access to JSVirtualMachine's
m_externalObjectGraph and m_externalRememberedSet need to be guarded by a lock
since both the GC marker thread and the mutator thread may access them at the
same time.

• API/JSVirtualMachine.mm:

(-[JSVirtualMachine addExternalRememberedObject:]):
(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):
(-[JSVirtualMachine externalDataMutex]):
(scanExternalObjectGraph):
(scanExternalRememberedSet):

• API/JSVirtualMachineInternal.h:
• Deleted externalObjectGraph method. There's no need to expose this.

File:

• trunk/Source/JavaScriptCore/API/JSVirtualMachineInternal.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/JSVirtualMachineInternal.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -48 +48 @@
 - (void)addContext:(JSContext *)wrapper forGlobalContextRef:(JSGlobalContextRef)globalContext;
 
-- (NSMapTable *)externalObjectGraph;
-
 @end
 #endif // defined(__OBJC__)