Changeset 210769 in webkit for trunk/Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py

Timestamp:

Jan 14, 2017, 11:35:23 AM (9 years ago)

Author:

Yusuke Suzuki

Message:

WebAssembly: Suppress warnings & errors in GCC
​https://bugs.webkit.org/show_bug.cgi?id=167049

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• wasm/WasmFunctionParser.h:

Add missing { } after the switch. Ideally, it is not necessary.
But in GCC, it is required. Since this function is fairly large,
I think the code generated by this does not cause performance
regression.

• wasm/WasmPageCount.h:

UINT_MAX is defined in limits.h.

• wasm/generateWasmValidateInlinesHeader.py:

On the other hand, we use this suppress pragma here to solve the
same problem in wasm/WasmFunctionParser.h. Since the load function
is fairly small, the additional return { }; may generate some
suboptimal code. See bug 150794 for more detail.

Source/WTF:

• wtf/LEBDecoder.h:

(WTF::LEBDecoder::decodeInt):
If T = int, it performs -1 << shift. It causes
warning in GCC. Instead, we first cast it to the
UnsignedT, perform operation and re-cast to the
T.

File:

• trunk/Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py (modified) (2 diffs)

trunk/Source/JavaScriptCore/wasm/generateWasmValidateInlinesHeader.py

@@ -126 +126 @@
 #if ENABLE(WEBASSEMBLY)
 
+#include <wtf/StdLibExtras.h>
+
+#if COMPILER(GCC) && ASSERT_DISABLED
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wreturn-type"
+#endif // COMPILER(GCC) && ASSERT_DISABLED
+
 namespace JSC { namespace Wasm {
 
@@ -152 +159 @@
 } } // namespace JSC::Wasm
 
+#if COMPILER(GCC) && ASSERT_DISABLED
+#pragma GCC diagnostic pop
+#endif // COMPILER(GCC) && ASSERT_DISABLED
+
 #endif // ENABLE(WEBASSEMBLY)