Changeset 211542 in webkit for trunk/Source/JavaScriptCore/runtime/SamplingProfiler.h

Timestamp:

Feb 1, 2017, 5:23:37 PM (8 years ago)

Author:

[email protected]

Message:

The sampling profile should have an option to sample from C frames.
​https://bugs.webkit.org/show_bug.cgi?id=167614

Reviewed by Saam Barati.

We should be able to use the sampling profiler, at least
internally, to trace C calls. This patch only modifies the JSC
shell although it would be nice to add it to the Web Inspector in
a future patch.

• runtime/Options.h:
• runtime/SamplingProfiler.cpp:

(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::recordJSFrame):
(JSC::CFrameWalker::CFrameWalker):
(JSC::CFrameWalker::walk):
(JSC::CFrameWalker::isCFrame):
(JSC::CFrameWalker::advanceToParentFrame):
(JSC::CFrameWalker::frame):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::StackFrame::displayName):

• runtime/SamplingProfiler.h:

(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):

File:

• trunk/Source/JavaScriptCore/runtime/SamplingProfiler.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/SamplingProfiler.h

@@ -52 +52 @@
             , callSiteIndex(callSiteIndex)
         { }
+
+        UnprocessedStackFrame(void* pc)
+            : cCodePC(pc)
+        { }
+
         UnprocessedStackFrame()
         {
             unverifiedCallee = JSValue::encode(JSValue());
-            verifiedCodeBlock = nullptr;
         }
 
+        void* cCodePC { nullptr };
         EncodedJSValue unverifiedCallee;
-        CodeBlock* verifiedCodeBlock;
+        CodeBlock* verifiedCodeBlock { nullptr };
         CallSiteIndex callSiteIndex;
     };
@@ -66 +71 @@
         Executable,
         Host,
-        Unknown 
+        C,
+        Unknown
     };
 
@@ -79 +85 @@
 
         FrameType frameType { FrameType::Unknown };
+        void* cCodePC { nullptr };
         ExecutableBase* executable { nullptr };
         JSObject* callee { nullptr };