Changeset 211816 in webkit for trunk/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp

Timestamp:

Feb 7, 2017, 10:08:56 AM (9 years ago)

Author:

Carlos Garcia Campos

Message:

[Soup] WebKitSoupRequestInputStream can still leave requests unfinished after r211773
​https://bugs.webkit.org/show_bug.cgi?id=167929

Reviewed by Michael Catanzaro.

The while loop to process the pending data requests was not a good idea, because having a new pending request
doesn't mean we have more data available, but that more data was requested.

• WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(webkitSoupRequestInputStreamPendingReadAsyncComplete): Process only one request if needed.

File:

• trunk/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp (modified) (1 diff)

trunk/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp

@@ -64 +64 @@
 static void webkitSoupRequestInputStreamPendingReadAsyncComplete(WebKitSoupRequestInputStream* stream)
 {
-    while (stream->priv->pendingAsyncRead) {
-        auto data = WTFMove(stream->priv->pendingAsyncRead);
+    if (auto data = WTFMove(stream->priv->pendingAsyncRead))
         webkitSoupRequestInputStreamReadAsyncResultComplete(data->task.get(), data->buffer, data->count);
-    }
 }