Changeset 212620 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Feb 19, 2017, 7:59:19 PM (8 years ago)

Author:

[email protected]

Message:

functionTestWasmModuleFunctions() should use a MarkedArgumentBuffer for storing args instead of a Vector.
​https://bugs.webkit.org/show_bug.cgi?id=168574

Reviewed by Filip Pizlo.

• jsc.cpp:

(callWasmFunction):
(functionTestWasmModuleFunctions):

• runtime/ArgList.h:

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -3070 +3070 @@
 }
 
-static JSValue callWasmFunction(VM* vm, JSGlobalObject* globalObject, JSWebAssemblyCallee* wasmCallee, Vector<JSValue>& boxedArgs)
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=168582.
+static JSValue callWasmFunction(VM* vm, JSGlobalObject* globalObject, JSWebAssemblyCallee* wasmCallee, const ArgList& boxedArgs)
 {
     JSValue firstArgument;
@@ -3136 +3137 @@
             JSArray* arguments = jsCast<JSArray*>(test->getIndexQuickly(1));
 
-            Vector<JSValue> boxedArgs;
+            MarkedArgumentBuffer boxedArgs;
             for (unsigned argIndex = 0; argIndex < arguments->length(); ++argIndex)
                 boxedArgs.append(box(exec, vm, arguments->getIndexQuickly(argIndex)));
@@ -3151 +3152 @@
                 CommaPrinter comma(", ");
                 for (unsigned argIndex = 0; argIndex < arguments->length(); ++argIndex)
-                    dataLog(comma, valueWithTypeOfWasmValue(exec, vm, boxedArgs[argIndex], arguments->getIndexQuickly(argIndex)));
+                    dataLog(comma, valueWithTypeOfWasmValue(exec, vm, boxedArgs.at(argIndex), arguments->getIndexQuickly(argIndex)));
                 dataLogLn();