Changeset 213088 in webkit for trunk/Source/JavaScriptCore/jit/JIT.cpp

Timestamp:

Feb 27, 2017, 1:08:38 PM (8 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r213019.
​https://bugs.webkit.org/show_bug.cgi?id=168925

"It broke 32-bit jsc tests in debug builds" (Requested by
saamyjoon on #webkit).

Reverted changeset:

"op_get_by_id_with_this should use inline caching"
​https://bugs.webkit.org/show_bug.cgi?id=162124
​http://trac.webkit.org/changeset/213019

File:

• trunk/Source/JavaScriptCore/jit/JIT.cpp (modified) (5 diffs)

trunk/Source/JavaScriptCore/jit/JIT.cpp

@@ -84 +84 @@
     , m_bytecodeOffset(std::numeric_limits<unsigned>::max())
     , m_getByIdIndex(UINT_MAX)
-    , m_getByIdWithThisIndex(UINT_MAX)
     , m_putByIdIndex(UINT_MAX)
     , m_byValInstructionIndex(UINT_MAX)
@@ -439 +438 @@
 
     m_getByIdIndex = 0;
-    m_getByIdWithThisIndex = 0;
     m_putByIdIndex = 0;
     m_byValInstructionIndex = 0;
@@ -495 +493 @@
         case op_get_by_id_unset:
         DEFINE_SLOWCASE_OP(op_get_by_id)
-        DEFINE_SLOWCASE_OP(op_get_by_id_with_this)
         DEFINE_SLOWCASE_OP(op_get_by_val)
         DEFINE_SLOWCASE_OP(op_instanceof)
@@ -555 +552 @@
 
     RELEASE_ASSERT(m_getByIdIndex == m_getByIds.size());
-    RELEASE_ASSERT(m_getByIdWithThisIndex == m_getByIdsWithThis.size());
     RELEASE_ASSERT(m_putByIdIndex == m_putByIds.size());
     RELEASE_ASSERT(m_callLinkInfoIndex == m_callCompilationInfo.size());
@@ -778 +774 @@
     for (unsigned i = m_getByIds.size(); i--;)
         m_getByIds[i].finalize(patchBuffer);
-    for (unsigned i = m_getByIdsWithThis.size(); i--;)
-        m_getByIdsWithThis[i].finalize(patchBuffer);
     for (unsigned i = m_putByIds.size(); i--;)
         m_putByIds[i].finalize(patchBuffer);