Changeset 213088 in webkit for trunk/Source/JavaScriptCore/jit/JIT.h

Timestamp:

Feb 27, 2017, 1:08:38 PM (8 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r213019.
​https://bugs.webkit.org/show_bug.cgi?id=168925

"It broke 32-bit jsc tests in debug builds" (Requested by
saamyjoon on #webkit).

Reverted changeset:

"op_get_by_id_with_this should use inline caching"
​https://bugs.webkit.org/show_bug.cgi?id=162124
​http://trac.webkit.org/changeset/213019

File:

• trunk/Source/JavaScriptCore/jit/JIT.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/jit/JIT.h

@@ -624 +624 @@
         void emitSlow_op_try_get_by_id(Instruction*, Vector<SlowCaseEntry>::iterator&);
         void emitSlow_op_get_by_id(Instruction*, Vector<SlowCaseEntry>::iterator&);
-        void emitSlow_op_get_by_id_with_this(Instruction*, Vector<SlowCaseEntry>::iterator&);
         void emitSlow_op_get_arguments_length(Instruction*, Vector<SlowCaseEntry>::iterator&);
         void emitSlow_op_get_by_val(Instruction*, Vector<SlowCaseEntry>::iterator&);
@@ -761 +760 @@
         MacroAssembler::Call callOperation(J_JITOperation_ESsiJI, int, StructureStubInfo*, GPRReg, UniquedStringImpl*);
         MacroAssembler::Call callOperation(WithProfileTag, J_JITOperation_ESsiJI, int, StructureStubInfo*, GPRReg, UniquedStringImpl*);
-        MacroAssembler::Call callOperation(WithProfileTag, J_JITOperation_ESsiJJI, int, StructureStubInfo*, GPRReg, GPRReg, UniquedStringImpl*);
 #else
         MacroAssembler::Call callOperation(J_JITOperation_ESsiJI, int, StructureStubInfo*, GPRReg, GPRReg, UniquedStringImpl*);
         MacroAssembler::Call callOperation(WithProfileTag, J_JITOperation_ESsiJI, int, StructureStubInfo*, GPRReg, GPRReg, UniquedStringImpl*);
-        MacroAssembler::Call callOperation(WithProfileTag, J_JITOperation_ESsiJJI, int, StructureStubInfo*, GPRReg, GPRReg, GPRReg, GPRReg, UniquedStringImpl*);
 #endif
         MacroAssembler::Call callOperation(J_JITOperation_EJI, int, GPRReg, UniquedStringImpl*);
@@ -936 +933 @@
         Vector<Label> m_labels;
         Vector<JITGetByIdGenerator> m_getByIds;
-        Vector<JITGetByIdWithThisGenerator> m_getByIdsWithThis;
         Vector<JITPutByIdGenerator> m_putByIds;
         Vector<ByValCompilationInfo> m_byValCompilationInfo;
@@ -951 +947 @@
 
         unsigned m_getByIdIndex;
-        unsigned m_getByIdWithThisIndex;
         unsigned m_putByIdIndex;
         unsigned m_byValInstructionIndex;