Ignore:
Timestamp:
Apr 7, 2017, 12:42:37 PM (8 years ago)
Author:
[email protected]
Message:

WebAssembly: Module::getOrCreateCodeBlock is wrong
​https://bugs.webkit.org/show_bug.cgi?id=170612

Reviewed by Keith Miller.

When we were getting a module's CodeBlock, we were checking if !runnable(),
and if !runnable(), we were re-creating the CodeBlock. This is wrong, since
!runnable() is true while the CodeBlock is compiling. Instead, we should check
if we've finished compiling, and if so, if that compilation failed.

  • wasm/WasmModule.cpp:

(JSC::Wasm::Module::getOrCreateCodeBlock):

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r215103 r215114  
     12017-04-07  Saam Barati  <[email protected]>
     2
     3        WebAssembly: Module::getOrCreateCodeBlock is wrong
     4        https://bugs.webkit.org/show_bug.cgi?id=170612
     5
     6        Reviewed by Keith Miller.
     7
     8        When we were getting a module's CodeBlock, we were checking if !runnable(),
     9        and if !runnable(), we were re-creating the CodeBlock. This is wrong, since
     10        !runnable() is true while the CodeBlock is compiling. Instead, we should check
     11        if we've finished compiling, and if so, if that compilation failed.
     12
     13        * wasm/WasmModule.cpp:
     14        (JSC::Wasm::Module::getOrCreateCodeBlock):
     15
    1162017-04-07  Saam Barati  <[email protected]>
    217
Note: See TracChangeset for help on using the changeset viewer.