Changeset 215465 in webkit for trunk/Source/WebCore/dom/Document.cpp

Timestamp:

Apr 18, 2017, 9:34:11 AM (8 years ago)

Author:

[email protected]

Message:

Break Document::m_associatedFormControls reference cycle.
<​https://webkit.org/b/170946>

Reviewed by Antti Koivisto.

There was a race between didAssociateFormControls() and didAssociateFormControlsTimerFired()
where detaching Document from its frame between the two would lead to an unbreakable reference
cycle between Document and its form elements.

Solve this by clearing the set of associated form elements in removedLastRef(), where we clear
all the other strong smart pointers to elements.

• dom/Document.cpp:

(WebCore::Document::removedLastRef):

File:

• trunk/Source/WebCore/dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/dom/Document.cpp

@@ -626 +626 @@
         m_fullScreenElementStack.clear();
 #endif
+        m_associatedFormControls.clear();
 
         detachParser();