Changeset 215637 in webkit for trunk/Source/JavaScriptCore/heap/LargeAllocation.h

Timestamp:

Apr 21, 2017, 2:14:15 PM (8 years ago)

Author:

[email protected]

Message:

Source/JavaScriptCore:
Unreviewed, rolling out r215620 and r215623.
​https://bugs.webkit.org/show_bug.cgi?id=171139

broke arm64 build (Requested by keith_miller on #webkit).

Reverted changesets:

"Add signaling API"
​https://bugs.webkit.org/show_bug.cgi?id=170976
​http://trac.webkit.org/changeset/215620

"Unreviewed, fix Cloop build."
​http://trac.webkit.org/changeset/215623

Patch by Commit Queue <​[email protected]> on 2017-04-21

Source/WTF:
Remove LL/SC from Atomics
​https://bugs.webkit.org/show_bug.cgi?id=171141

Reviewed by Saam Barati.

Adding load link and store conditionally was not an actual progression
and the existing code is causing problems for users of Atomics. So let's
get rid of it.

• wtf/Atomics.h:

(WTF::hasFence):
(WTF::Atomic::exchange):
(WTF::Atomic::transaction):
(WTF::Atomic::transactionRelaxed):
(WTF::Atomic::prepare): Deleted.
(WTF::Atomic::attempt): Deleted.

• wtf/Bitmap.h:

(WTF::WordType>::concurrentTestAndSet):
(WTF::WordType>::concurrentTestAndClear):

• wtf/LockAlgorithm.h:

(WTF::LockAlgorithm::lockFast):
(WTF::LockAlgorithm::unlockFast):

File:

• trunk/Source/JavaScriptCore/heap/LargeAllocation.h (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/LargeAllocation.h

@@ -122 +122 @@
         return m_isMarked.compareExchangeStrong(false, true);
     }
-    ALWAYS_INLINE bool testAndSetMarked(HeapCell*, Dependency, TransactionAbortLikelihood = TransactionAbortLikelihood::Likely) { return testAndSetMarked(); }
+    ALWAYS_INLINE bool testAndSetMarked(HeapCell*, Dependency) { return testAndSetMarked(); }
     void clearMarked() { m_isMarked.store(false); }