Changeset 2167 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 25, 2002, 1:25:23 PM (23 years ago)

Author:

darin

Message:

• fixed 3057964 -- JS problem performing MD5 script embedded in yahoo login page

• kjs/simple_number.h: Fix incorrect check for sign bit that was munging numbers in the range 0x10000000 to 0x1FFFFFFF.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ChangeLog-2002-12-03 (modified) (1 diff)
• ChangeLog-2003-10-25 (modified) (1 diff)
• kjs/simple_number.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2002-09-25  Darin Adler  <[email protected]>
+
+        - fixed 3057964 -- JS problem performing MD5 script embedded in yahoo login page
+
+        * kjs/simple_number.h: Fix incorrect check for sign bit that was munging numbers
+        in the range 0x10000000 to 0x1FFFFFFF.
+
 === Alexander-24 ===
 

trunk/JavaScriptCore/ChangeLog-2002-12-03

@@ +1 @@
+2002-09-25  Darin Adler  <[email protected]>
+
+        - fixed 3057964 -- JS problem performing MD5 script embedded in yahoo login page
+
+        * kjs/simple_number.h: Fix incorrect check for sign bit that was munging numbers
+        in the range 0x10000000 to 0x1FFFFFFF.
+
 === Alexander-24 ===
 

trunk/JavaScriptCore/ChangeLog-2003-10-25

@@ +1 @@
+2002-09-25  Darin Adler  <[email protected]>
+
+        - fixed 3057964 -- JS problem performing MD5 script embedded in yahoo login page
+
+        * kjs/simple_number.h: Fix incorrect check for sign bit that was munging numbers
+        in the range 0x10000000 to 0x1FFFFFFF.
+
 === Alexander-24 ===
 

trunk/JavaScriptCore/kjs/simple_number.h

@@ -32 +32 @@
     class SimpleNumber {
     public:
-        enum { tag = 1, shift = 2, mask = (1 << shift) - 1, max = (1 << (31 - shift)) - 1, min = -max - 1 };
+        enum { tag = 1, shift = 2, mask = (1 << shift) - 1, sign = 1 << 31, max = (1 << (31 - shift)) - 1, min = -max - 1 };
 
         static inline bool is(const ValueImp *imp) { return ((int)imp & mask) == tag; }
-        static inline int value(const ValueImp *imp) { return ((int)imp >> shift) | (((int)imp & min) ? ~max : 0); }
+        static inline int value(const ValueImp *imp) { return ((int)imp >> shift) | (((int)imp & sign) ? ~max : 0); }
 
         static inline bool fits(int i) { return i <= max && i >= min; }