Changeset 2168 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 25, 2002, 3:46:33 PM (23 years ago)

Author:

hyatt

Message:

Fix the impls of min/max to not use +inf/-inf when you have
arguments. Technically there's still a bug here for the no
argument case, probably caused by a screwup when +inf/-inf are
converted to doubles.

• kjs/math_object.cpp: (MathFuncImp::call):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ChangeLog-2002-12-03 (modified) (1 diff)
• ChangeLog-2003-10-25 (modified) (1 diff)
• kjs/math_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2002-09-25  David Hyatt  <[email protected]>
+
+        Fix the impls of min/max to not use +inf/-inf when you have
+        arguments.  Technically there's still a bug here for the no
+        argument case, probably caused by a screwup when +inf/-inf are
+        converted to doubles.
+        
+        * kjs/math_object.cpp:
+        (MathFuncImp::call):
+
 2002-09-25  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2002-12-03

@@ +1 @@
+2002-09-25  David Hyatt  <[email protected]>
+
+        Fix the impls of min/max to not use +inf/-inf when you have
+        arguments.  Technically there's still a bug here for the no
+        argument case, probably caused by a screwup when +inf/-inf are
+        converted to doubles.
+        
+        * kjs/math_object.cpp:
+        (MathFuncImp::call):
+
 2002-09-25  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2003-10-25

@@ +1 @@
+2002-09-25  David Hyatt  <[email protected]>
+
+        Fix the impls of min/max to not use +inf/-inf when you have
+        arguments.  Technically there's still a bug here for the no
+        argument case, probably caused by a screwup when +inf/-inf are
+        converted to doubles.
+        
+        * kjs/math_object.cpp:
+        (MathFuncImp::call):
+
 2002-09-25  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/kjs/math_object.cpp

@@ -183 +183 @@
       if ( isNaN( val ) )
       {
-        result = NaN;
+            result = NaN;
         break;
       }
-      if ( val > result )
+      // Comparing a number to negative infinity doesn't work.  
+      // -dwh
+      if ( k == 0 || val > result )
         result = val;
     }
@@ -201 +203 @@
         break;
       }
-      if ( val < result )
+      // Comparing a number to positive infinity doesn't work.  
+      // -dwh
+      if ( k == 0 || val < result )
         result = val;
     }