Changeset 2173 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 26, 2002, 8:20:47 AM (23 years ago)

Author:

darin

Message:

Fix the infinity problem Dave worked around. We didn't have the
configuration flags set right to make infinity work. Setting those
properly made everything work without changes to min and max.

• kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and also WORDS_BIGENDIAN (if on ppc).

• kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max changes from yesterday.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• ChangeLog-2002-12-03 (modified) (1 diff)
• ChangeLog-2003-10-25 (modified) (1 diff)
• kjs/config.h (modified) (1 diff)
• kjs/math_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2002-09-26  Darin Adler  <[email protected]>
+
+        Fix the infinity problem Dave worked around. We didn't have the
+        configuration flags set right to make infinity work. Setting those
+        properly made everything work without changes to min and max.
+
+        * kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and
+        also WORDS_BIGENDIAN (if on ppc).
+
+        * kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max
+        changes from yesterday.
+
 2002-09-25  David Hyatt  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2002-12-03

@@ +1 @@
+2002-09-26  Darin Adler  <[email protected]>
+
+        Fix the infinity problem Dave worked around. We didn't have the
+        configuration flags set right to make infinity work. Setting those
+        properly made everything work without changes to min and max.
+
+        * kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and
+        also WORDS_BIGENDIAN (if on ppc).
+
+        * kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max
+        changes from yesterday.
+
 2002-09-25  David Hyatt  <[email protected]>
 

trunk/JavaScriptCore/ChangeLog-2003-10-25

@@ +1 @@
+2002-09-26  Darin Adler  <[email protected]>
+
+        Fix the infinity problem Dave worked around. We didn't have the
+        configuration flags set right to make infinity work. Setting those
+        properly made everything work without changes to min and max.
+
+        * kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and
+        also WORDS_BIGENDIAN (if on ppc).
+
+        * kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max
+        changes from yesterday.
+
 2002-09-25  David Hyatt  <[email protected]>
 

trunk/JavaScriptCore/kjs/config.h

@@ -1 @@
-
+#define HAVE_FUNC_ISINF 1
+#define HAVE_FUNC_ISNAN 1
+#define HAVE_STRING_H 1
+#define HAVE_STRINGS_H 1
+#define HAVE_SYS_TIME_H 1
 #define TIME_WITH_SYS_TIME 1
-#define HAVE_SYS_TIME_H 1
-#define HAVE_FUNC_ISNAN 1
-#define HAVE_STRINGS_H
+#ifdef __ppc__
+#define WORDS_BIGENDIAN 1
+#endif

trunk/JavaScriptCore/kjs/math_object.cpp

@@ -183 +183 @@
       if ( isNaN( val ) )
       {
-            result = NaN;
+        result = NaN;
         break;
       }
-      // Comparing a number to negative infinity doesn't work.  
-      // -dwh
-      if ( k == 0 || val > result )
+      if ( val > result )
         result = val;
     }
@@ -203 +201 @@
         break;
       }
-      // Comparing a number to positive infinity doesn't work.  
-      // -dwh
-      if ( k == 0 || val < result )
+      if ( val < result )
         result = val;
     }