Changeset 218080 in webkit for trunk/Source/JavaScriptCore/runtime/MachineContext.h

Timestamp:

Jun 11, 2017, 5:47:18 PM (8 years ago)

Author:

Yusuke Suzuki

Message:

[WTF] Make ThreadMessage portable
​https://bugs.webkit.org/show_bug.cgi?id=172073

Reviewed by Keith Miller.

Source/JavaScriptCore:

• runtime/MachineContext.h:

(JSC::MachineContext::stackPointer):

• tools/CodeProfiling.cpp:

(JSC::profilingTimer):

Source/WTF:

Recently, we change ThreadMessage semantics: message handler
can be executed in the sender thread.
This allows ThreadMessage to be implemented in a portable way.

This patch implements ThreadMessage for all the platforms.
We use platform-independent Thread APIs, suspend(), resume(),
and getRegisters().

• wtf/PlatformRegisters.h:

(WTF::registersFromUContext):

• wtf/ThreadMessage.cpp:

(WTF::sendMessageScoped):
(WTF::ThreadMessageData::ThreadMessageData): Deleted.
(): Deleted.
(WTF::initializeThreadMessages): Deleted.
(WTF::sendMessageUsingSignal): Deleted.
(WTF::sendMessageUsingMach): Deleted.
(WTF::deliverMessagesUsingMach): Deleted.

• wtf/ThreadMessage.h:
• wtf/Threading.cpp:

(WTF::initializeThreading):

• wtf/Threading.h:

(WTF::Thread::threadMessages): Deleted.

• wtf/ThreadingPthreads.cpp:

(WTF::Thread::signalHandlerSuspendResume):
(WTF::threadStateMetadata):
(WTF::Thread::getRegisters):

• wtf/threads/Signals.cpp:

(WTF::handleSignalsWithMach):

File:

• trunk/Source/JavaScriptCore/runtime/MachineContext.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/MachineContext.h

@@ -34 +34 @@
 namespace MachineContext {
 
-
+void* stackPointer(const PlatformRegisters&);
+
+#if OS(WINDOWS) || HAVE(MACHINE_CONTEXT)
 void*& stackPointer(PlatformRegisters&);
-void* stackPointer(const PlatformRegisters&);
-
-#if OS(WINDOWS) || HAVE(MACHINE_CONTEXT)
 void*& framePointer(PlatformRegisters&);
 void* framePointer(const PlatformRegisters&);
@@ -65 +64 @@
 #endif // OS(WINDOWS) || HAVE(MACHINE_CONTEXT)
 
+#if OS(WINDOWS) || HAVE(MACHINE_CONTEXT)
 inline void*& stackPointer(PlatformRegisters& regs)
 {
@@ -112 +112 @@
 #elif HAVE(MACHINE_CONTEXT)
     return stackPointer(regs.machineContext);
-#else
+#endif
+}
+
+inline void* stackPointer(const PlatformRegisters& regs)
+{
+    return stackPointer(const_cast<PlatformRegisters&>(regs));
+}
+#else // not OS(WINDOWS) || HAVE(MACHINE_CONTEXT)
+inline void* stackPointer(const PlatformRegisters& regs)
+{
     return regs.stackPointer;
-#endif
-}
-
-inline void* stackPointer(const PlatformRegisters& regs)
-{
-    return stackPointer(const_cast<PlatformRegisters&>(regs));
-}
-
+}
+#endif // OS(WINDOWS) || HAVE(MACHINE_CONTEXT)
 
 #if HAVE(MACHINE_CONTEXT)