Changeset 218218 in webkit for trunk/Source/JavaScriptCore/bytecode/PropertyCondition.cpp

Timestamp:

Jun 13, 2017, 3:39:34 PM (8 years ago)

Author:

[email protected]

Message:

Refactor AbsenceOfSetter to AbsenceOfSetEffects
​https://bugs.webkit.org/show_bug.cgi?id=173322

Reviewed by Filip Pizlo.

• bytecode/ObjectPropertyCondition.h:

(JSC::ObjectPropertyCondition::absenceOfSetEffectWithoutBarrier):
(JSC::ObjectPropertyCondition::absenceOfSetEffect):
(JSC::ObjectPropertyCondition::absenceOfSetterWithoutBarrier): Deleted.
(JSC::ObjectPropertyCondition::absenceOfSetter): Deleted.

• bytecode/ObjectPropertyConditionSet.cpp:

(JSC::generateConditionsForPropertySetterMiss):
(JSC::generateConditionsForPropertySetterMissConcurrently):

• bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::dumpInContext):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):
(JSC::PropertyCondition::isStillValid):
(WTF::printInternal):

• bytecode/PropertyCondition.h:

(JSC::PropertyCondition::absenceOfSetEffectWithoutBarrier):
(JSC::PropertyCondition::absenceOfSetEffect):
(JSC::PropertyCondition::hasPrototype):
(JSC::PropertyCondition::hash):
(JSC::PropertyCondition::operator==):
(JSC::PropertyCondition::absenceOfSetterWithoutBarrier): Deleted.
(JSC::PropertyCondition::absenceOfSetter): Deleted.

File:

• trunk/Source/JavaScriptCore/bytecode/PropertyCondition.cpp (modified) (5 diffs)

trunk/Source/JavaScriptCore/bytecode/PropertyCondition.cpp

@@ -48 +48 @@
         return;
     case Absence:
-    case AbsenceOfSetter:
+    case AbsenceOfSetEffect:
         out.print(" with prototype ", inContext(JSValue(prototype()), context));
         return;
@@ -125 +125 @@
     }
     
-    case AbsenceOfSetter: {
+    case AbsenceOfSetEffect: {
         if (structure->isDictionary()) {
             if (verbose)
@@ -135 +135 @@
         PropertyOffset currentOffset = structure->getConcurrently(uid(), currentAttributes);
         if (currentOffset != invalidOffset) {
-            // FIXME: Given the addition of the check for ReadOnly attributes, we should refactor
-            // instances of AbsenceOfSetter.
-            // https://bugs.webkit.org/show_bug.cgi?id=173322 - Refactor AbsenceOfSetter to something like AbsenceOfSetEffects
             if (currentAttributes & (ReadOnly | Accessor | CustomAccessor)) {
                 if (verbose) {
@@ -224 +221 @@
     // Currently we assume that an impure property can cause a property to appear, and can also
     // "shadow" an existing JS property on the same object. Hence it affects both presence and
-    // absence. It doesn't affect AbsenceOfSetter because impure properties aren't ever setters.
+    // absence. It doesn't affect AbsenceOfSetEffect because impure properties aren't ever setters.
     switch (m_kind) {
     case Absence:
@@ -355 +352 @@
         out.print("Absence");
         return;
-    case JSC::PropertyCondition::AbsenceOfSetter:
+    case JSC::PropertyCondition::AbsenceOfSetEffect:
         out.print("Absence");
         return;