Changeset 218784 in webkit for trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp

Timestamp:

Jun 24, 2017, 1:06:47 AM (8 years ago)

Author:

[email protected]

Message:

Remove Reflect.enumerate
​https://bugs.webkit.org/show_bug.cgi?id=173806

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-06-24
Reviewed by Yusuke Suzuki.

JSTests:

• ChakraCore.yaml:
• es6.yaml:

These tests now fail because they use Reflect.enumerate.

• test262.yaml:

This test now passes, it checked that Reflect.enumerate is undefined!

• stress/property-name-enumerator-should-not-look-into-indexed-values-when-it-is-a-dictionary.js:

Convert to for..in which presented the original issue. See bug <​https://webkit.org/b/149811>

• stress/reflect-enumerate.js: Removed.

Remove a test solely for Reflect.enumerate.

Source/JavaScriptCore:

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::JSInjectedScriptHost::iteratorEntries):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSPropertyNameIterator.cpp: Removed.
• runtime/JSPropertyNameIterator.h: Removed.
• runtime/ReflectObject.cpp:

(JSC::reflectObjectEnumerate): Deleted.

Source/WebInspectorUI:

• UserInterface/Models/NativeFunctionParameters.js:

Tools:

• Scripts/run-jsc-stress-tests:

LayoutTests:

• inspector/model/remote-object-expected.txt:
• inspector/model/remote-object.html:
• platform/mac/inspector/model/remote-object-expected.txt:

File:

• trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp

@@ -30 +30 @@
 #include "JSCInlines.h"
 #include "JSGlobalObjectFunctions.h"
-#include "JSPropertyNameIterator.h"
 #include "Lookup.h"
 #include "ObjectConstructor.h"
@@ -38 +37 @@
 static EncodedJSValue JSC_HOST_CALL reflectObjectConstruct(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectDefineProperty(ExecState*);
-static EncodedJSValue JSC_HOST_CALL reflectObjectEnumerate(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectGet(ExecState*);
 static EncodedJSValue JSC_HOST_CALL reflectObjectGetOwnPropertyDescriptor(ExecState*);
@@ -64 +62 @@
     defineProperty           reflectObjectDefineProperty           DontEnum|Function 3
     deleteProperty           JSBuiltin                             DontEnum|Function 2
-    enumerate                reflectObjectEnumerate                DontEnum|Function 1
     get                      reflectObjectGet                      DontEnum|Function 2
     getOwnPropertyDescriptor reflectObjectGetOwnPropertyDescriptor DontEnum|Function 2
@@ -157 +154 @@
 }
 
-// FIXME: Reflect.enumerate is removed in ECMA 2016 draft.
-// http://www.ecma-international.org/ecma-262/6.0/#sec-reflect.enumerate
-EncodedJSValue JSC_HOST_CALL reflectObjectEnumerate(ExecState* exec)
-{
-    VM& vm = exec->vm();
-    auto scope = DECLARE_THROW_SCOPE(vm);
-
-    JSValue target = exec->argument(0);
-    if (!target.isObject())
-        return JSValue::encode(throwTypeError(exec, scope, ASCIILiteral("Reflect.enumerate requires the first argument be an object")));
-    scope.release();
-    return JSValue::encode(JSPropertyNameIterator::create(exec, exec->lexicalGlobalObject()->propertyNameIteratorStructure(), asObject(target)));
-}
-
 // https://tc39.github.io/ecma262/#sec-reflect.get
 EncodedJSValue JSC_HOST_CALL reflectObjectGet(ExecState* exec)