Ignore:
Timestamp:
Jul 10, 2017, 11:24:26 AM (8 years ago)
Author:
BJ Burg
Message:

Web Replay: remove some unused code
​https://bugs.webkit.org/show_bug.cgi?id=173903

Rubber-stamped by Joseph Pecoraro.

.:

  • ManualTests/inspector/replay-keyboard-events.html: Removed.
  • ManualTests/inspector/replay-mouse-events.html: Removed.
  • ManualTests/inspector/replay-wheel-events.html: Removed.
  • ManualTests/inspector/replay-window-navigator-basic.html: Removed.
  • ManualTests/inspector/replay-window-screen.html: Removed.
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/protocol/Replay.json: Removed.
  • replay/EmptyInputCursor.h: Removed.
  • replay/EncodedValue.cpp: Removed.
  • replay/EncodedValue.h: Removed.
  • replay/InputCursor.h: Removed.
  • replay/JSInputs.json: Removed.
  • replay/NondeterministicInput.h: Removed.
  • replay/scripts/CodeGeneratorReplayInputs.py: Removed.
  • replay/scripts/CodeGeneratorReplayInputsTemplates.py: Removed.
  • replay/scripts/tests/expected/fail-on-c-style-enum-no-storage.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-duplicate-enum-type.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-duplicate-input-names.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-duplicate-type-names.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-enum-type-missing-values.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-missing-input-member-name.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-missing-input-name.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-missing-input-queue.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-missing-type-mode.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-missing-type-name.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-unknown-input-queue.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-unknown-member-type.json-error: Removed.
  • replay/scripts/tests/expected/fail-on-unknown-type-mode.json-error: Removed.
  • replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/expected/generate-event-loop-shape-types.json-error: Removed.
  • replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/expected/generate-inputs-with-flags.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-inputs-with-flags.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/expected/generate-memoized-type-modes.json-TestReplayInputs.cpp: Removed.
  • replay/scripts/tests/expected/generate-memoized-type-modes.json-TestReplayInputs.h: Removed.
  • replay/scripts/tests/fail-on-c-style-enum-no-storage.json: Removed.
  • replay/scripts/tests/fail-on-duplicate-enum-type.json: Removed.
  • replay/scripts/tests/fail-on-duplicate-input-names.json: Removed.
  • replay/scripts/tests/fail-on-duplicate-type-names.json: Removed.
  • replay/scripts/tests/fail-on-enum-type-missing-values.json: Removed.
  • replay/scripts/tests/fail-on-missing-input-member-name.json: Removed.
  • replay/scripts/tests/fail-on-missing-input-name.json: Removed.
  • replay/scripts/tests/fail-on-missing-input-queue.json: Removed.
  • replay/scripts/tests/fail-on-missing-type-mode.json: Removed.
  • replay/scripts/tests/fail-on-missing-type-name.json: Removed.
  • replay/scripts/tests/fail-on-unknown-input-queue.json: Removed.
  • replay/scripts/tests/fail-on-unknown-member-type.json: Removed.
  • replay/scripts/tests/fail-on-unknown-type-mode.json: Removed.
  • replay/scripts/tests/generate-enum-encoding-helpers-with-guarded-values.json: Removed.
  • replay/scripts/tests/generate-enum-encoding-helpers.json: Removed.
  • replay/scripts/tests/generate-enum-with-guard.json: Removed.
  • replay/scripts/tests/generate-enums-with-same-base-name.json: Removed.
  • replay/scripts/tests/generate-event-loop-shape-types.json: Removed.
  • replay/scripts/tests/generate-input-with-guard.json: Removed.
  • replay/scripts/tests/generate-input-with-vector-members.json: Removed.
  • replay/scripts/tests/generate-inputs-with-flags.json: Removed.
  • replay/scripts/tests/generate-memoized-type-modes.json: Removed.
  • runtime/DateConstructor.cpp:

(JSC::constructDate):
(JSC::dateNow):
(JSC::deterministicCurrentTime): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::setInputCursor): Deleted.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::inputCursor): Deleted.

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::lastModified):
(WebCore::Document::inputCursor): Deleted.
(WebCore::Document::setInputCursor): Deleted.

  • dom/Document.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::sessionCreatedImpl): Deleted.
(WebCore::InspectorInstrumentation::sessionLoadedImpl): Deleted.
(WebCore::InspectorInstrumentation::sessionModifiedImpl): Deleted.
(WebCore::InspectorInstrumentation::segmentCreatedImpl): Deleted.
(WebCore::InspectorInstrumentation::segmentCompletedImpl): Deleted.
(WebCore::InspectorInstrumentation::segmentLoadedImpl): Deleted.
(WebCore::InspectorInstrumentation::segmentUnloadedImpl): Deleted.
(WebCore::InspectorInstrumentation::captureStartedImpl): Deleted.
(WebCore::InspectorInstrumentation::captureStoppedImpl): Deleted.
(WebCore::InspectorInstrumentation::playbackStartedImpl): Deleted.
(WebCore::InspectorInstrumentation::playbackPausedImpl): Deleted.
(WebCore::InspectorInstrumentation::playbackHitPositionImpl): Deleted.
(WebCore::InspectorInstrumentation::playbackFinishedImpl): Deleted.
(WebCore::InspectorInstrumentation::replayAgentEnabled): Deleted.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::sessionCreated): Deleted.
(WebCore::InspectorInstrumentation::sessionLoaded): Deleted.
(WebCore::InspectorInstrumentation::sessionModified): Deleted.
(WebCore::InspectorInstrumentation::segmentCreated): Deleted.
(WebCore::InspectorInstrumentation::segmentCompleted): Deleted.
(WebCore::InspectorInstrumentation::segmentLoaded): Deleted.
(WebCore::InspectorInstrumentation::segmentUnloaded): Deleted.
(WebCore::InspectorInstrumentation::captureStarted): Deleted.
(WebCore::InspectorInstrumentation::captureStopped): Deleted.
(WebCore::InspectorInstrumentation::playbackStarted): Deleted.
(WebCore::InspectorInstrumentation::playbackPaused): Deleted.
(WebCore::InspectorInstrumentation::playbackFinished): Deleted.
(WebCore::InspectorInstrumentation::playbackHitPosition): Deleted.

  • inspector/InspectorReplayAgent.cpp: Removed.
  • inspector/InspectorReplayAgent.h: Removed.
  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::reset):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorReplayAgent): Deleted.
(WebCore::InstrumentingAgents::setInspectorReplayAgent): Deleted.

  • page/EventHandler.h:
  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::replayController): Deleted.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::synchronousScrollingReasons):
(WebCore::ScrollingCoordinator::replaySessionStateDidChange): Deleted.

  • page/scrolling/ScrollingCoordinator.h:
  • platform/Logging.h:
  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::getPluginData):

  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::pluginData):

  • replay/AllReplayInputs.h: Removed.
  • replay/CapturingInputCursor.cpp: Removed.
  • replay/CapturingInputCursor.h: Removed.
  • replay/EventLoopInput.cpp: Removed.
  • replay/EventLoopInput.h: Removed.
  • replay/EventLoopInputDispatcher.cpp: Removed.
  • replay/EventLoopInputDispatcher.h: Removed.
  • replay/FunctorInputCursor.h: Removed.
  • replay/MemoizedDOMResult.cpp: Removed.
  • replay/MemoizedDOMResult.h: Removed.
  • replay/ReplayController.cpp: Removed.
  • replay/ReplayController.h: Removed.
  • replay/ReplayInputCreationMethods.cpp: Removed.
  • replay/ReplayInputDispatchMethods.cpp: Removed.
  • replay/ReplaySession.cpp: Removed.
  • replay/ReplaySession.h: Removed.
  • replay/ReplaySessionSegment.cpp: Removed.
  • replay/ReplaySessionSegment.h: Removed.
  • replay/ReplayingInputCursor.cpp: Removed.
  • replay/ReplayingInputCursor.h: Removed.
  • replay/SegmentedInputStorage.cpp: Removed.
  • replay/SegmentedInputStorage.h: Removed.
  • replay/SerializationMethods.cpp: Removed.
  • replay/SerializationMethods.h: Removed.
  • replay/WebInputs.json: Removed.

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

  • .eslintrc:
  • UserInterface/Base/Main.js:

(WebInspector.loaded):

  • UserInterface/Controllers/DashboardManager.js:

(WebInspector.DashboardManager):

  • UserInterface/Controllers/ReplayManager.js: Removed.
  • UserInterface/Images/ReplayPauseButton.svg: Removed.
  • UserInterface/Images/ReplayPlayButton.svg: Removed.
  • UserInterface/Images/ReplayRecordingButton.svg: Removed.
  • UserInterface/Images/gtk/ReplayPauseButton.svg: Removed.
  • UserInterface/Images/gtk/ReplayPlayButton.svg: Removed.
  • UserInterface/Images/gtk/ReplayRecordingButton.svg: Removed.
  • UserInterface/Main.html:
  • UserInterface/Models/ReplayDashboard.js: Removed.
  • UserInterface/Models/ReplaySession.js: Removed.
  • UserInterface/Models/ReplaySessionSegment.js: Removed.
  • UserInterface/Protocol/ReplayObserver.js: Removed.
  • UserInterface/Test.html:
  • UserInterface/Test/Test.js:

(WebInspector.loaded):

  • UserInterface/Views/DashboardView.js:

(WebInspector.DashboardView.create):

  • UserInterface/Views/ReplayDashboardView.css: Removed.
  • UserInterface/Views/ReplayDashboardView.js: Removed.
  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._debuggerPaused):
(WebInspector.TimelineRecordingContentView.prototype._debuggerResumed):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::tryClose):
(WebKit::WebPage::loadRequest):
(WebKit::WebPage::stopLoadingFrame):
(WebKit::WebPage::stopLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::contextMenuAtPointInWindow):
(WebKit::handleContextMenuEvent):
(WebKit::handleMouseEvent):
(WebKit::handleWheelEvent):
(WebKit::handleKeyEvent):
(WebKit::WebPage::scroll):
(WebKit::WebPage::logicalScroll):

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/run-input-generator-tests: Removed.
  • Scripts/webkitpy/replay/init.py: Removed.
  • Scripts/webkitpy/replay/main.py: Removed.

LayoutTests:

  • inspector/replay/javascript-date-now-expected.txt: Removed.
  • inspector/replay/javascript-date-now.html: Removed.
  • inspector/replay/javascript-random-seed-expected.txt: Removed.
  • inspector/replay/javascript-random-seed.html: Removed.
  • inspector/replay/window-navigator-plugins-memoized-expected.txt: Removed.
  • inspector/replay/window-navigator-plugins-memoized.html: Removed.
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h

    r218951 r219301  
    383383    VM& m_vm;
    384384
    385 #if ENABLE(WEB_REPLAY)
    386     Ref<InputCursor> m_inputCursor;
    387 #endif
    388 
    389385#if ENABLE(REMOTE_INSPECTOR)
    390386    std::unique_ptr<Inspector::JSGlobalObjectInspectorController> m_inspectorController;
    … …  
    653649    JS_EXPORT_PRIVATE bool remoteDebuggingEnabled() const;
    654650
    655 #if ENABLE(WEB_REPLAY)
    656     JS_EXPORT_PRIVATE void setInputCursor(Ref<InputCursor>&&);
    657     InputCursor& inputCursor() const { return m_inputCursor.get(); }
    658 #endif
    659 
    660651#if ENABLE(REMOTE_INSPECTOR)
    661652    Inspector::JSGlobalObjectInspectorController& inspectorController() const { return *m_inspectorController.get(); }
Note: See TracChangeset for help on using the changeset viewer.