Changeset 219636 in webkit for trunk/Source/JavaScriptCore/runtime/JSArray.h

Timestamp:

Jul 18, 2017, 3:40:59 PM (8 years ago)

Author:

[email protected]

Message:

Butterfly storage need not be initialized for indexing type Undecided.
​https://bugs.webkit.org/show_bug.cgi?id=174516

Reviewed by Saam Barati.

While it's not incorrect to initialize the butterfly storage when the
indexingType is Undecided, it is inefficient as we'll end up initializing
it again later when we convert the storage to a different indexingType.
Some of our code already skips initializing Undecided butterflies.
This patch makes it the consistent behavior everywhere.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):

• runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):

• runtime/JSArray.h:

(JSC::JSArray::tryCreate):

• runtime/JSObject.cpp:

(JSC::JSObject::ensureLengthSlow):

File:

• trunk/Source/JavaScriptCore/runtime/JSArray.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSArray.h

@@ -240 +240 @@
         if (hasDouble(indexingType))
             clearArray(butterfly->contiguousDouble().data(), vectorLength);
-        else
+        else if (LIKELY(!hasUndecided(indexingType)))
             clearArray(butterfly->contiguous().data(), vectorLength);
     } else {