Changeset 219648 in webkit for trunk/Source/JavaScriptCore/b3

Timestamp:

Jul 18, 2017, 10:47:23 PM (8 years ago)

Author:

[email protected]

Message:

[Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
​https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Tim Horton.

Source/bmalloc:

• Configurations/Base.xcconfig:

Source/JavaScriptCore:

• Configurations/Base.xcconfig:
• b3/B3FoldPathConstants.cpp:
• b3/B3LowerMacros.cpp:
• b3/air/AirAllocateRegistersByGraphColoring.cpp:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::check):
(JSC::DFG::ByteCodeParser::planLoad):

Source/ThirdParty/ANGLE:

• Configurations/Base.xcconfig:

Source/WebCore:

• Configurations/Base.xcconfig:
• rendering/Grid.cpp:

(WebCore::Grid::insert):

• rendering/RenderTreeAsText.cpp:

(WebCore::write):

• rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::printSimpleLineLayoutCoverage):

Source/WebCore/PAL:

• Configurations/Base.xcconfig:

Source/WebInspectorUI:

• Configurations/Base.xcconfig:

Source/WebKit:

• Configurations/Base.xcconfig:
• Shared/API/APIArray.cpp:

(API::Array::toStringVector):

• UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray):

• UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel presentWithParameters:resultListener:]):

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

Source/WebKitLegacy/mac:

• Configurations/Base.xcconfig:

Source/WTF:

• Configurations/Base.xcconfig:

Tools:

• DumpRenderTree/mac/Configurations/Base.xcconfig:
• MiniBrowser/Configurations/Base.xcconfig:
• MobileMiniBrowser/Configurations/Base.xcconfig:
• TestWebKitAPI/Configurations/Base.xcconfig:
• WebKitTestRunner/Configurations/Base.xcconfig:

Location:

trunk/Source/JavaScriptCore/b3

Files:

• B3FoldPathConstants.cpp (modified) (1 diff)
• B3LowerMacros.cpp (modified) (1 diff)
• air/AirAllocateRegistersByGraphColoring.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/b3/B3FoldPathConstants.cpp

@@ -104 +104 @@
 
                 HashMap<BasicBlock*, unsigned> targetUses;
-                for (const SwitchCase& switchCase : switchValue->cases(block))
+                for (SwitchCase switchCase : switchValue->cases(block))
                     targetUses.add(switchCase.targetBlock(), 0).iterator->value++;
                 targetUses.add(switchValue->fallThrough(block), 0).iterator->value++;
 
-                for (const SwitchCase& switchCase : switchValue->cases(block)) {
+                for (SwitchCase switchCase : switchValue->cases(block)) {
                     if (targetUses.find(switchCase.targetBlock())->value != 1)
                         continue;

trunk/Source/JavaScriptCore/b3/B3LowerMacros.cpp

@@ -181 +181 @@
                 SwitchValue* switchValue = m_value->as<SwitchValue>();
                 Vector<SwitchCase> cases;
-                for (const SwitchCase& switchCase : switchValue->cases(m_block))
+                for (SwitchCase switchCase : switchValue->cases(m_block))
                     cases.append(switchCase);
                 std::sort(

trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp

@@ -1654 +1654 @@
             };
 
-            for (const Tmp& liveTmp : localCalc.live())
+            for (Tmp liveTmp : localCalc.live())
                 considerEdge(liveTmp);
             for (const Tmp& pinnedRegTmp : m_pinnedRegs)
@@ -1700 +1700 @@
                     return;
                 
-                for (const Tmp& liveTmp : liveTmps) {
+                for (Tmp liveTmp : liveTmps) {
                     ASSERT(liveTmp.isGP() == (bank == GP));