Changeset 219702 in webkit for trunk/Source/JavaScriptCore/b3

Timestamp:

Jul 20, 2017, 2:06:12 PM (8 years ago)

Author:

Chris Dumez

Message:

Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
​https://bugs.webkit.org/show_bug.cgi?id=174660

Reviewed by Geoffrey Garen.

Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
This essentially replaces a branch to figure out if the new size is less or greater than the
current size by an assertion.

Source/bmalloc:

• bmalloc/Map.h:

(bmalloc::Hash>::rehash):

Source/JavaScriptCore:

• b3/B3BasicBlockUtils.h:

(JSC::B3::clearPredecessors):

• b3/B3InferSwitches.cpp:
• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::finishAppendingInstructions):

• b3/B3ReduceStrength.cpp:
• b3/B3SparseCollection.h:

(JSC::B3::SparseCollection::packIndices):

• b3/B3UseCounts.cpp:

(JSC::B3::UseCounts::UseCounts):

• b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:
• b3/air/AirEmitShuffle.cpp:

(JSC::B3::Air::emitShuffle):

• b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

• b3/air/AirOptimizeBlockOrder.cpp:

(JSC::B3::Air::optimizeBlockOrder):

• bytecode/Operands.h:

(JSC::Operands::ensureLocals):

• bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargetsInternal):

• dfg/DFGBlockInsertionSet.cpp:

(JSC::DFG::BlockInsertionSet::execute):

• dfg/DFGBlockMapInlines.h:

(JSC::DFG::BlockMap<T>::BlockMap):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processSetLocalQueue):
(JSC::DFG::ByteCodeParser::clearCaches):

• dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::Disassembler):

• dfg/DFGFlowIndexing.cpp:

(JSC::DFG::FlowIndexing::recompute):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::registerFrozenValues):

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::setLiveValues):

• dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):

• dfg/DFGLivenessAnalysisPhase.cpp:
• dfg/DFGNaturalLoops.cpp:

(JSC::DFG::NaturalLoops::NaturalLoops):

• dfg/DFGStoreBarrierClusteringPhase.cpp:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):

• heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::sweepLargeAllocations):

• inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

• interpreter/ShadowChicken.cpp:

(JSC::ShadowChicken::update):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::shrinkOperandStackBy):

• parser/Lexer.h:

(JSC::Lexer::setOffset):

• runtime/RegExpInlines.h:

(JSC::RegExp::matchInline):

• runtime/RegExpPrototype.cpp:

(JSC::genericSplit):

• yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::match):

Source/WebCore:

• Modules/gamepad/Gamepad.cpp:

(WebCore::Gamepad::Gamepad):

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::addReaction):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::skipBuffer):

• Modules/websockets/WebSocketDeflater.cpp:

(WebCore::WebSocketDeflater::finish):

• contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeSelector):

• contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::append):

• crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):

• crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:

(WebCore::gcryptDerive):

• platform/gamepad/cocoa/GameControllerGamepadProvider.mm:

(WebCore::GameControllerGamepadProvider::controllerDidConnect):

• platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::deviceAdded):

• platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::setSize):

• platform/graphics/WOFFFileFormat.cpp:
• platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:

(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes):
(WebCore::InbandMetadataTextTrackPrivateAVF::flushPartialCues):

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::resetCueValues):
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):

• platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer):

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::cfData):

• platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::frameBufferAtIndex):

• platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decode):

• platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::frameBufferAtIndex):

• platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::readChunks):

• platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::frameBufferAtIndex):

• platform/image-encoders/JPEGImageEncoder.cpp:

(WebCore::compressRGBABigEndianToJPEG):

• platform/text/DecodeEscapeSequences.h:

(WebCore::URLEscapeSequence::decodeRun):

• platform/text/SuffixTree.h:

(WebCore::SuffixTree::Node::Node):

• rendering/Grid.cpp:

(WebCore::Grid::setNeedsItemsPlacement):

• rendering/RenderTable.cpp:

(WebCore::RenderTable::invalidateCachedColumns):

Source/WebKit:

• Platform/IPC/ArgumentCoders.h:
• UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::platformGamepadConnected):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setInitialConnectedGamepads):

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResourceSynchronously):

• WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:

(WebKit::WebPasteboardOverrides::getDataForOverride):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAutocorrectionData):

Source/WebKitLegacy/mac:

• Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

Source/WTF:

• wtf/IndexSparseSet.h:

(WTF::OverflowHandler>::IndexSparseSet):
(WTF::OverflowHandler>::clear):

• wtf/Insertion.h:

(WTF::executeInsertions):

• wtf/RangeSet.h:

(WTF::RangeSet::compact):

• wtf/Vector.h:

(WTF::removeRepeatedElements):

• wtf/persistence/Coders.h:

Location:

trunk/Source/JavaScriptCore/b3

Files:

• B3BasicBlockUtils.h (modified) (1 diff)
• B3InferSwitches.cpp (modified) (1 diff)
• B3LowerToAir.cpp (modified) (1 diff)
• B3ReduceStrength.cpp (modified) (1 diff)
• B3SparseCollection.h (modified) (1 diff)
• B3UseCounts.cpp (modified) (1 diff)
• air/AirAllocateRegistersAndStackByLinearScan.cpp (modified) (1 diff)
• air/AirEmitShuffle.cpp (modified) (1 diff)
• air/AirLowerAfterRegAlloc.cpp (modified) (1 diff)
• air/AirOptimizeBlockOrder.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/b3/B3BasicBlockUtils.h

@@ -90 +90 @@
     for (auto& block : blocks) {
         if (block)
-            block->predecessors().resize(0);
+            block->predecessors().shrink(0);
     }
 }

trunk/Source/JavaScriptCore/b3/B3InferSwitches.cpp

@@ -196 +196 @@
         }
         m_insertionSet.execute(predecessor);
-        block->values().resize(0);
+        block->values().shrink(0);
         block->appendNew<Value>(m_proc, Oops, description.branch->origin());
         block->removePredecessor(predecessor);

trunk/Source/JavaScriptCore/b3/B3LowerToAir.cpp

@@ -1185 +1185 @@
                 target->appendInst(WTFMove(inst));
         }
-        m_insts.resize(0);
+        m_insts.shrink(0);
     }
     

trunk/Source/JavaScriptCore/b3/B3ReduceStrength.cpp

@@ -2371 +2371 @@
                     // Make sure that the successor has nothing left in it. Make sure that the block
                     // has a terminal so that nobody chokes when they look at it.
-                    successor->values().resize(0);
+                    successor->values().shrink(0);
                     successor->appendNew<Value>(m_proc, Oops, jumpOrigin);
                     successor->clearSuccessors();

trunk/Source/JavaScriptCore/b3/B3SparseCollection.h

@@ -108 +108 @@
         }
 
-        m_indexFreeList.resize(0);
-        m_vector.resize(endIndex);
+        m_indexFreeList.shrink(0);
+        m_vector.shrink(endIndex);
     }
 

trunk/Source/JavaScriptCore/b3/B3UseCounts.cpp

@@ -38 +38 @@
     Vector<Value*, 64> children;
     for (Value* value : procedure.values()) {
-        children.resize(0);
+        children.shrink(0);
         for (Value* child : value->children()) {
             m_counts[child].numUses++;

trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp

@@ -334 +334 @@
     void prepareIntervals(const SelectFunc& selectFunc)
     {
-        m_tmps.resize(0);
+        m_tmps.shrink(0);
         
         m_code.forEachTmp(

trunk/Source/JavaScriptCore/b3/air/AirEmitShuffle.cpp

@@ -276 +276 @@
                     ASSERT(rotate.loop[i].dst() == rotate.loop[i + 1].src());
                 rotates.append(WTFMove(rotate));
-                currentPairs.resize(0);
+                currentPairs.shrink(0);
             } else {
                 if (verbose)

trunk/Source/JavaScriptCore/b3/air/AirLowerAfterRegAlloc.cpp

@@ -233 +233 @@
 
                 // Now we need to emit code to restore registers.
-                pairs.resize(0);
+                pairs.shrink(0);
                 unsigned stackSlotIndex = 0;
                 regsToSave.forEach(

trunk/Source/JavaScriptCore/b3/air/AirOptimizeBlockOrder.cpp

@@ -65 +65 @@
             worklist.push(m_successors[i]);
         
-        m_successors.resize(0);
+        m_successors.shrink(0);
     }
 
@@ -138 +138 @@
         entry.release();
 
-    code.blockList().resize(0);
+    code.blockList().shrink(0);
 
     for (unsigned i = 0; i < blocksInOrder.size(); ++i) {