Changeset 219696 in webkit for trunk/Source/JavaScriptCore/runtime/JSLock.cpp

Timestamp:

Jul 20, 2017, 11:32:13 AM (8 years ago)

Author:

Yusuke Suzuki

Message:

[WTF] Use ThreadGroup to bookkeep active threads for Mach exception
​https://bugs.webkit.org/show_bug.cgi?id=174678

Reviewed by Mark Lam.

Source/JavaScriptCore:

Use Thread& instead.

• runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

Source/WTF:

We can use ThreadGroup to bookkeep active threads for Mach exceptions.
When the thread dies, it is automatically removed from the thread groups.
So we do not need to call unregisterThreadForMachExceptionHandling.

• wtf/ThreadGroup.cpp:

(WTF::ThreadGroup::~ThreadGroup):
(WTF::ThreadGroup::add):

• wtf/ThreadGroup.h:
• wtf/ThreadHolder.cpp:

(WTF::ThreadHolder::~ThreadHolder):

• wtf/Threading.cpp:

(WTF::Thread::addToThreadGroup):
(WTF::Thread::removeFromThreadGroup):

• wtf/Threading.h:
• wtf/threads/Signals.cpp:

(WTF::setExceptionPorts):
(WTF::activeThreads):
(WTF::registerThreadForMachExceptionHandling):
(WTF::installSignalHandler):
(WTF::unregisterThreadForMachExceptionHandling): Deleted.

• wtf/threads/Signals.h:

File:

• trunk/Source/JavaScriptCore/runtime/JSLock.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSLock.cpp

@@ -152 +152 @@
 
 #if HAVE(MACH_EXCEPTIONS)
-    registerThreadForMachExceptionHandling(&Thread::current());
+    registerThreadForMachExceptionHandling(Thread::current());
 #endif