Changeset 221404 in webkit for trunk/Source/JavaScriptCore/runtime/Lookup.cpp

Timestamp:

Aug 30, 2017, 3:54:22 PM (8 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r221327.

This change caused test262 failures.

Reverted changeset:

"[JSC] Use reifying system for "name" property of builtin
JSFunction"
​https://bugs.webkit.org/show_bug.cgi?id=175260
​http://trac.webkit.org/changeset/221327

File:

• trunk/Source/JavaScriptCore/runtime/Lookup.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Lookup.cpp

@@ -32 +32 @@
     GetterSetter* accessor = GetterSetter::create(vm, globalObject);
     if (value.accessorGetter()) {
-        JSFunction* function = nullptr;
-        if (value.attributes() & Builtin)
-            function = JSFunction::create(vm, value.builtinAccessorGetterGenerator()(vm), globalObject);
-        else {
-            String getterName = tryMakeString(ASCIILiteral("get "), String(*propertyName.publicName()));
-            if (!getterName)
-                return;
-            function = JSFunction::create(vm, globalObject, 0, getterName, value.accessorGetter());
-        }
-        accessor->setGetter(vm, globalObject, function);
+        String getterName = tryMakeString(ASCIILiteral("get "), String(*propertyName.publicName()));
+        if (!getterName)
+            return;
+        accessor->setGetter(vm, globalObject, value.attributes() & Builtin
+            ? JSFunction::createBuiltinFunction(vm, value.builtinAccessorGetterGenerator()(vm), globalObject, getterName)
+            : JSFunction::create(vm, globalObject, 0, getterName, value.accessorGetter()));
     }
     thisObject.putDirectNonIndexAccessor(vm, propertyName, accessor, attributesForStructure(value.attributes()));