Changeset 221475 in webkit for trunk/Source/JavaScriptCore/runtime/InternalFunction.cpp

Timestamp:

Aug 31, 2017, 11:40:55 PM (8 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Fix "name" and "length" of Proxy revoke function
​https://bugs.webkit.org/show_bug.cgi?id=176155

Reviewed by Mark Lam.

JSTests:

• test262.yaml:

Source/JavaScriptCore:

ProxyRevoke's length should be configurable. And it does not have
its own name. We add NameVisibility enum to InternalFunction to
control visibility of the name.

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

• runtime/InternalFunction.h:
• runtime/ProxyRevoke.cpp:

(JSC::ProxyRevoke::finishCreation):

File:

• trunk/Source/JavaScriptCore/runtime/InternalFunction.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/InternalFunction.cpp

@@ -42 +42 @@
 }
 
-void InternalFunction::finishCreation(VM& vm, const String& name)
+void InternalFunction::finishCreation(VM& vm, const String& name, NameVisibility nameVisibility)
 {
     Base::finishCreation(vm);
@@ -49 +49 @@
     JSString* nameString = jsString(&vm, name);
     m_originalName.set(vm, this, nameString);
-    putDirect(vm, vm.propertyNames->name, nameString, ReadOnly | DontEnum);
+    if (nameVisibility == NameVisibility::Visible)
+        putDirect(vm, vm.propertyNames->name, nameString, ReadOnly | DontEnum);
 }