Changeset 222473 in webkit for trunk/Source/JavaScriptCore/ChangeLog
- Timestamp:
- Sep 25, 2017, 3:37:03 PM (8 years ago)
- File:
-
- 1 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r222425 r222473 1 2017-09-25 Alex Christensen <[email protected]> 2 3 Make Attribute an enum class 4 https://bugs.webkit.org/show_bug.cgi?id=177414 5 6 Reviewed by Yusuke Suzuki. 7 8 I've had enough of these naming collisions. This is what enum classes are for. 9 Unfortunately a lot of static_cast<unsigned> is necessary until those functions take 10 an OptionSet<Attribute> instead of an unsigned parameter, but this is a big step 11 towards where we ought to be. 12 13 * API/JSCallbackObjectFunctions.h: 14 (JSC::JSCallbackObject<Parent>::getOwnPropertySlot): 15 * API/JSObjectRef.cpp: 16 (JSObjectMakeConstructor): 17 * Scripts/builtins/builtins_generate_internals_wrapper_implementation.py: 18 (BuiltinsInternalsWrapperImplementationGenerator.property_macro): 19 * bytecode/GetByIdStatus.cpp: 20 (JSC::GetByIdStatus::computeFromLLInt): 21 (JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback): 22 (JSC::GetByIdStatus::computeFor): 23 * bytecode/PropertyCondition.cpp: 24 (JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const): 25 (JSC::PropertyCondition::isValidValueForAttributes): 26 * bytecode/PutByIdStatus.cpp: 27 (JSC::PutByIdStatus::computeFor): 28 * bytecompiler/BytecodeGenerator.cpp: 29 (JSC::BytecodeGenerator::instantiateLexicalVariables): 30 (JSC::BytecodeGenerator::variable): 31 * bytecompiler/BytecodeGenerator.h: 32 (JSC::Variable::isReadOnly const): 33 (JSC::Variable::setIsReadOnly): 34 * bytecompiler/NodesCodegen.cpp: 35 (JSC::PropertyListNode::emitBytecode): 36 * create_hash_table: 37 * debugger/DebuggerScope.cpp: 38 (JSC::DebuggerScope::getOwnPropertySlot): 39 * dfg/DFGOperations.cpp: 40 * inspector/JSInjectedScriptHostPrototype.cpp: 41 (Inspector::JSInjectedScriptHostPrototype::finishCreation): 42 * inspector/JSJavaScriptCallFramePrototype.cpp: 43 (Inspector::JSJavaScriptCallFramePrototype::finishCreation): 44 * jit/Repatch.cpp: 45 (JSC::tryCacheGetByID): 46 * jsc.cpp: 47 (WTF::CustomGetter::getOwnPropertySlot): 48 (WTF::RuntimeArray::getOwnPropertySlot): 49 (WTF::RuntimeArray::getOwnPropertySlotByIndex): 50 (WTF::DOMJITGetter::finishCreation): 51 (WTF::DOMJITGetterComplex::finishCreation): 52 (WTF::DOMJITFunctionObject::finishCreation): 53 (WTF::DOMJITCheckSubClassObject::finishCreation): 54 (GlobalObject::finishCreation): 55 * runtime/ArrayConstructor.cpp: 56 (JSC::ArrayConstructor::finishCreation): 57 * runtime/ArrayIteratorPrototype.cpp: 58 (JSC::ArrayIteratorPrototype::finishCreation): 59 * runtime/ArrayPrototype.cpp: 60 (JSC::ArrayPrototype::finishCreation): 61 * runtime/AsyncFromSyncIteratorPrototype.cpp: 62 (JSC::AsyncFromSyncIteratorPrototype::finishCreation): 63 * runtime/AsyncFunctionConstructor.cpp: 64 (JSC::AsyncFunctionConstructor::finishCreation): 65 * runtime/AsyncFunctionPrototype.cpp: 66 (JSC::AsyncFunctionPrototype::finishCreation): 67 * runtime/AsyncGeneratorFunctionConstructor.cpp: 68 (JSC::AsyncGeneratorFunctionConstructor::finishCreation): 69 * runtime/AsyncGeneratorFunctionPrototype.cpp: 70 (JSC::AsyncGeneratorFunctionPrototype::finishCreation): 71 * runtime/AsyncGeneratorPrototype.cpp: 72 (JSC::AsyncGeneratorPrototype::finishCreation): 73 * runtime/AsyncIteratorPrototype.cpp: 74 (JSC::AsyncIteratorPrototype::finishCreation): 75 * runtime/AtomicsObject.cpp: 76 (JSC::AtomicsObject::finishCreation): 77 * runtime/BooleanConstructor.cpp: 78 (JSC::BooleanConstructor::finishCreation): 79 * runtime/ClonedArguments.cpp: 80 (JSC::ClonedArguments::createStructure): 81 (JSC::ClonedArguments::getOwnPropertySlot): 82 (JSC::ClonedArguments::materializeSpecials): 83 * runtime/CommonSlowPaths.cpp: 84 (JSC::SLOW_PATH_DECL): 85 * runtime/ConsoleObject.cpp: 86 (JSC::ConsoleObject::finishCreation): 87 * runtime/DateConstructor.cpp: 88 (JSC::DateConstructor::finishCreation): 89 * runtime/DatePrototype.cpp: 90 (JSC::DatePrototype::finishCreation): 91 * runtime/DirectArguments.cpp: 92 (JSC::DirectArguments::overrideThings): 93 * runtime/Error.cpp: 94 (JSC::addErrorInfo): 95 * runtime/ErrorConstructor.cpp: 96 (JSC::ErrorConstructor::finishCreation): 97 * runtime/ErrorInstance.cpp: 98 (JSC::ErrorInstance::finishCreation): 99 * runtime/ErrorPrototype.cpp: 100 (JSC::ErrorPrototype::finishCreation): 101 * runtime/FunctionConstructor.cpp: 102 (JSC::FunctionConstructor::finishCreation): 103 * runtime/FunctionPrototype.cpp: 104 (JSC::FunctionPrototype::finishCreation): 105 (JSC::FunctionPrototype::addFunctionProperties): 106 (JSC::FunctionPrototype::initRestrictedProperties): 107 * runtime/GeneratorFunctionConstructor.cpp: 108 (JSC::GeneratorFunctionConstructor::finishCreation): 109 * runtime/GeneratorFunctionPrototype.cpp: 110 (JSC::GeneratorFunctionPrototype::finishCreation): 111 * runtime/GeneratorPrototype.cpp: 112 (JSC::GeneratorPrototype::finishCreation): 113 * runtime/GenericArgumentsInlines.h: 114 (JSC::GenericArguments<Type>::getOwnPropertySlot): 115 (JSC::GenericArguments<Type>::getOwnPropertySlotByIndex): 116 * runtime/InternalFunction.cpp: 117 (JSC::InternalFunction::finishCreation): 118 * runtime/IntlCollatorConstructor.cpp: 119 (JSC::IntlCollatorConstructor::finishCreation): 120 * runtime/IntlDateTimeFormatConstructor.cpp: 121 (JSC::IntlDateTimeFormatConstructor::finishCreation): 122 * runtime/IntlDateTimeFormatPrototype.cpp: 123 (JSC::IntlDateTimeFormatPrototype::finishCreation): 124 * runtime/IntlNumberFormatConstructor.cpp: 125 (JSC::IntlNumberFormatConstructor::finishCreation): 126 * runtime/IntlObject.cpp: 127 (JSC::IntlObject::finishCreation): 128 * runtime/IteratorPrototype.cpp: 129 (JSC::IteratorPrototype::finishCreation): 130 * runtime/JSArray.cpp: 131 (JSC::JSArray::getOwnPropertySlot): 132 (JSC::JSArray::setLengthWithArrayStorage): 133 * runtime/JSArrayBufferConstructor.cpp: 134 (JSC::JSArrayBufferConstructor::finishCreation): 135 * runtime/JSArrayBufferPrototype.cpp: 136 (JSC::JSArrayBufferPrototype::finishCreation): 137 * runtime/JSBoundFunction.cpp: 138 (JSC::JSBoundFunction::finishCreation): 139 * runtime/JSCJSValue.cpp: 140 (JSC::JSValue::putToPrimitive): 141 * runtime/JSDataView.cpp: 142 (JSC::JSDataView::getOwnPropertySlot): 143 * runtime/JSDataViewPrototype.cpp: 144 (JSC::JSDataViewPrototype::finishCreation): 145 * runtime/JSFunction.cpp: 146 (JSC::JSFunction::finishCreation): 147 (JSC::JSFunction::getOwnPropertySlot): 148 (JSC::JSFunction::defineOwnProperty): 149 (JSC::JSFunction::reifyLength): 150 (JSC::JSFunction::reifyName): 151 (JSC::JSFunction::reifyLazyBoundNameIfNeeded): 152 * runtime/JSGenericTypedArrayViewConstructorInlines.h: 153 (JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation): 154 * runtime/JSGenericTypedArrayViewInlines.h: 155 (JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot): 156 (JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex): 157 * runtime/JSGenericTypedArrayViewPrototypeInlines.h: 158 (JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation): 159 * runtime/JSGlobalObject.cpp: 160 (JSC::JSGlobalObject::init): 161 (JSC::JSGlobalObject::addStaticGlobals): 162 * runtime/JSLexicalEnvironment.cpp: 163 (JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames): 164 * runtime/JSModuleNamespaceObject.cpp: 165 (JSC::JSModuleNamespaceObject::finishCreation): 166 (JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon): 167 * runtime/JSONObject.cpp: 168 (JSC::JSONObject::finishCreation): 169 * runtime/JSObject.cpp: 170 (JSC::getClassPropertyNames): 171 (JSC::JSObject::getOwnPropertySlotByIndex): 172 (JSC::ordinarySetSlow): 173 (JSC::JSObject::putInlineSlow): 174 (JSC::JSObject::putGetter): 175 (JSC::JSObject::putSetter): 176 (JSC::JSObject::putDirectAccessor): 177 (JSC::JSObject::putDirectCustomAccessor): 178 (JSC::JSObject::putDirectNonIndexAccessor): 179 (JSC::JSObject::deleteProperty): 180 (JSC::JSObject::deletePropertyByIndex): 181 (JSC::JSObject::getOwnPropertyNames): 182 (JSC::JSObject::putIndexedDescriptor): 183 (JSC::JSObject::defineOwnIndexedProperty): 184 (JSC::JSObject::attemptToInterceptPutByIndexOnHoleForPrototype): 185 (JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength): 186 (JSC::JSObject::getOwnPropertyDescriptor): 187 (JSC::putDescriptor): 188 (JSC::validateAndApplyPropertyDescriptor): 189 * runtime/JSObject.h: 190 (JSC::JSObject::putDirect): 191 * runtime/JSObjectInlines.h: 192 (JSC::JSObject::putDirectWithoutTransition): 193 (JSC::JSObject::putDirectInternal): 194 * runtime/JSPromiseConstructor.cpp: 195 (JSC::JSPromiseConstructor::finishCreation): 196 (JSC::JSPromiseConstructor::addOwnInternalSlots): 197 * runtime/JSPromisePrototype.cpp: 198 (JSC::JSPromisePrototype::finishCreation): 199 (JSC::JSPromisePrototype::addOwnInternalSlots): 200 * runtime/JSString.cpp: 201 (JSC::JSString::getStringPropertyDescriptor): 202 * runtime/JSString.h: 203 (JSC::JSString::getStringPropertySlot): 204 * runtime/JSSymbolTableObject.cpp: 205 (JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames): 206 * runtime/JSSymbolTableObject.h: 207 (JSC::symbolTableGet): 208 * runtime/JSTypedArrayViewConstructor.cpp: 209 (JSC::JSTypedArrayViewConstructor::finishCreation): 210 * runtime/JSTypedArrayViewPrototype.cpp: 211 (JSC::JSTypedArrayViewPrototype::finishCreation): 212 * runtime/LazyClassStructure.cpp: 213 (JSC::LazyClassStructure::Initializer::setConstructor): 214 * runtime/Lookup.cpp: 215 (JSC::reifyStaticAccessor): 216 (JSC::setUpStaticFunctionSlot): 217 * runtime/Lookup.h: 218 (JSC::HashTableValue::intrinsic const): 219 (JSC::HashTableValue::builtinGenerator const): 220 (JSC::HashTableValue::function const): 221 (JSC::HashTableValue::functionLength const): 222 (JSC::HashTableValue::propertyGetter const): 223 (JSC::HashTableValue::propertyPutter const): 224 (JSC::HashTableValue::domJIT const): 225 (JSC::HashTableValue::signature const): 226 (JSC::HashTableValue::accessorGetter const): 227 (JSC::HashTableValue::accessorSetter const): 228 (JSC::HashTableValue::constantInteger const): 229 (JSC::HashTableValue::lazyCellPropertyOffset const): 230 (JSC::HashTableValue::lazyClassStructureOffset const): 231 (JSC::HashTableValue::lazyPropertyCallback const): 232 (JSC::HashTableValue::builtinAccessorGetterGenerator const): 233 (JSC::HashTableValue::builtinAccessorSetterGenerator const): 234 (JSC::getStaticPropertySlotFromTable): 235 (JSC::putEntry): 236 (JSC::reifyStaticProperty): 237 * runtime/MapConstructor.cpp: 238 (JSC::MapConstructor::finishCreation): 239 * runtime/MapIteratorPrototype.cpp: 240 (JSC::MapIteratorPrototype::finishCreation): 241 * runtime/MapPrototype.cpp: 242 (JSC::MapPrototype::finishCreation): 243 * runtime/MathObject.cpp: 244 (JSC::MathObject::finishCreation): 245 * runtime/NativeErrorConstructor.cpp: 246 (JSC::NativeErrorConstructor::finishCreation): 247 * runtime/NativeErrorPrototype.cpp: 248 (JSC::NativeErrorPrototype::finishCreation): 249 * runtime/NumberConstructor.cpp: 250 (JSC::NumberConstructor::finishCreation): 251 * runtime/NumberPrototype.cpp: 252 (JSC::NumberPrototype::finishCreation): 253 * runtime/ObjectConstructor.cpp: 254 (JSC::ObjectConstructor::finishCreation): 255 (JSC::objectConstructorAssign): 256 (JSC::objectConstructorValues): 257 (JSC::objectConstructorDefineProperty): 258 * runtime/ObjectPrototype.cpp: 259 (JSC::ObjectPrototype::finishCreation): 260 (JSC::objectProtoFuncLookupGetter): 261 (JSC::objectProtoFuncLookupSetter): 262 * runtime/ProgramExecutable.cpp: 263 (JSC::ProgramExecutable::initializeGlobalProperties): 264 * runtime/PropertyDescriptor.cpp: 265 (JSC::PropertyDescriptor::writable const): 266 (JSC::PropertyDescriptor::enumerable const): 267 (JSC::PropertyDescriptor::configurable const): 268 (JSC::PropertyDescriptor::setUndefined): 269 (JSC::PropertyDescriptor::setDescriptor): 270 (JSC::PropertyDescriptor::setCustomDescriptor): 271 (JSC::PropertyDescriptor::setAccessorDescriptor): 272 (JSC::PropertyDescriptor::setWritable): 273 (JSC::PropertyDescriptor::setEnumerable): 274 (JSC::PropertyDescriptor::setConfigurable): 275 (JSC::PropertyDescriptor::setSetter): 276 (JSC::PropertyDescriptor::setGetter): 277 (JSC::PropertyDescriptor::attributesEqual const): 278 (JSC::PropertyDescriptor::attributesOverridingCurrent const): 279 * runtime/PropertySlot.cpp: 280 (JSC::PropertySlot::customGetter const): 281 * runtime/PropertySlot.h: 282 (JSC::operator| ): 283 (JSC::operator&): 284 (JSC::operator<): 285 (JSC::operator~): 286 (JSC::operator|=): 287 (JSC::PropertySlot::setUndefined): 288 * runtime/ProxyConstructor.cpp: 289 (JSC::makeRevocableProxy): 290 (JSC::ProxyConstructor::finishCreation): 291 * runtime/ProxyObject.cpp: 292 (JSC::ProxyObject::performHasProperty): 293 * runtime/ProxyRevoke.cpp: 294 (JSC::ProxyRevoke::finishCreation): 295 * runtime/ReflectObject.cpp: 296 (JSC::ReflectObject::finishCreation): 297 (JSC::reflectObjectDefineProperty): 298 * runtime/RegExpConstructor.cpp: 299 (JSC::RegExpConstructor::finishCreation): 300 * runtime/RegExpObject.cpp: 301 (JSC::RegExpObject::getOwnPropertySlot): 302 * runtime/RegExpPrototype.cpp: 303 (JSC::RegExpPrototype::finishCreation): 304 * runtime/ScopedArguments.cpp: 305 (JSC::ScopedArguments::overrideThings): 306 * runtime/SetConstructor.cpp: 307 (JSC::SetConstructor::finishCreation): 308 * runtime/SetIteratorPrototype.cpp: 309 (JSC::SetIteratorPrototype::finishCreation): 310 * runtime/SetPrototype.cpp: 311 (JSC::SetPrototype::finishCreation): 312 * runtime/SparseArrayValueMap.cpp: 313 (JSC::SparseArrayValueMap::putDirect): 314 (JSC::SparseArrayEntry::put): 315 * runtime/StringConstructor.cpp: 316 (JSC::StringConstructor::finishCreation): 317 * runtime/StringIteratorPrototype.cpp: 318 (JSC::StringIteratorPrototype::finishCreation): 319 * runtime/StringPrototype.cpp: 320 (JSC::StringPrototype::finishCreation): 321 * runtime/Structure.cpp: 322 (JSC::Structure::nonPropertyTransition): 323 (JSC::Structure::isSealed): 324 (JSC::Structure::isFrozen): 325 (JSC::Structure::getPropertyNamesFromStructure): 326 (JSC::Structure::prototypeChainMayInterceptStoreTo): 327 * runtime/StructureInlines.h: 328 (JSC::Structure::add): 329 * runtime/SymbolConstructor.cpp: 330 (JSC::SymbolConstructor::finishCreation): 331 * runtime/SymbolPrototype.cpp: 332 (JSC::SymbolPrototype::finishCreation): 333 * runtime/SymbolTable.h: 334 (JSC::SymbolTableEntry::Fast::getAttributes const): 335 (JSC::SymbolTableEntry::SymbolTableEntry): 336 (JSC::SymbolTableEntry::setAttributes): 337 * runtime/TemplateRegistry.cpp: 338 (JSC::TemplateRegistry::getTemplateObject): 339 * runtime/WeakMapConstructor.cpp: 340 (JSC::WeakMapConstructor::finishCreation): 341 * runtime/WeakMapPrototype.cpp: 342 (JSC::WeakMapPrototype::finishCreation): 343 * runtime/WeakSetConstructor.cpp: 344 (JSC::WeakSetConstructor::finishCreation): 345 * runtime/WeakSetPrototype.cpp: 346 (JSC::WeakSetPrototype::finishCreation): 347 * tools/JSDollarVMPrototype.cpp: 348 (JSC::JSDollarVMPrototype::finishCreation): 349 * wasm/js/WebAssemblyCompileErrorConstructor.cpp: 350 (JSC::WebAssemblyCompileErrorConstructor::finishCreation): 351 * wasm/js/WebAssemblyInstanceConstructor.cpp: 352 (JSC::WebAssemblyInstanceConstructor::finishCreation): 353 * wasm/js/WebAssemblyLinkErrorConstructor.cpp: 354 (JSC::WebAssemblyLinkErrorConstructor::finishCreation): 355 * wasm/js/WebAssemblyMemoryConstructor.cpp: 356 (JSC::WebAssemblyMemoryConstructor::finishCreation): 357 * wasm/js/WebAssemblyMemoryPrototype.cpp: 358 * wasm/js/WebAssemblyModuleConstructor.cpp: 359 (JSC::WebAssemblyModuleConstructor::finishCreation): 360 * wasm/js/WebAssemblyRuntimeErrorConstructor.cpp: 361 (JSC::WebAssemblyRuntimeErrorConstructor::finishCreation): 362 * wasm/js/WebAssemblyTableConstructor.cpp: 363 (JSC::WebAssemblyTableConstructor::finishCreation): 364 1 365 2017-09-23 Oleksandr Skachkov <[email protected]> 2 366
Note:
See TracChangeset
for help on using the changeset viewer.