Ignore:
Timestamp:
Sep 25, 2017, 6:40:30 PM (8 years ago)
Author:
[email protected]
Message:

Web Inspector: move Console.addInspectedNode to DOM.setInspectedNode
https://bugs.webkit.org/show_bug.cgi?id=176827

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/agents/InspectorConsoleAgent.h:
  • inspector/agents/JSGlobalObjectConsoleAgent.h:
  • inspector/agents/JSGlobalObjectConsoleAgent.cpp:

(Inspector::JSGlobalObjectConsoleAgent::addInspectedNode): Deleted.

  • inspector/protocol/Console.json:
  • inspector/protocol/DOM.json:

Source/WebCore:

Tests: http/tests/inspector/dom/cross-domain-inspected-node-access.html

inspector/dom/setInspectedNode.html

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setInspectedNode):

  • inspector/PageConsoleAgent.h:
  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::addInspectedNode): Deleted.

  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::addInspectedNode): Deleted.

Source/WebInspectorUI:

  • UserInterface/Controllers/DOMTreeManager.js:

(WI.DOMTreeManager):
(WI.DOMTreeManager.prototype.setInspectedNode):

  • UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype._selectedNodeDidChange):

LayoutTests:

  • http/tests/inspector/dom/cross-domain-inspected-node-access-expected.txt: Renamed from LayoutTests/http/tests/inspector/console/cross-domain-inspected-node-access-expected.txt.
  • http/tests/inspector/dom/cross-domain-inspected-node-access.html: Renamed from LayoutTests/http/tests/inspector/console/cross-domain-inspected-node-access.html.
  • inspector/console/command-line-api.html:
  • inspector/dom/setInspectedNode-expected.txt: Renamed from LayoutTests/inspector/console/addInspectedNode-expected.txt.
  • inspector/dom/setInspectedNode.html: Renamed from LayoutTests/inspector/console/addInspectedNode.html.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r222481 r222486  
     12017-09-25  Devin Rousso  <[email protected]>
     2
     3        Web Inspector: move Console.addInspectedNode to DOM.setInspectedNode
     4        https://bugs.webkit.org/show_bug.cgi?id=176827
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * inspector/agents/InspectorConsoleAgent.h:
     9
     10        * inspector/agents/JSGlobalObjectConsoleAgent.h:
     11        * inspector/agents/JSGlobalObjectConsoleAgent.cpp:
     12        (Inspector::JSGlobalObjectConsoleAgent::addInspectedNode): Deleted.
     13
     14        * inspector/protocol/Console.json:
     15        * inspector/protocol/DOM.json:
     16
    1172017-09-25  Ryan Haddad  <[email protected]>
    218
Note: See TracChangeset for help on using the changeset viewer.