Changeset 222499 in webkit for trunk/Source/JavaScriptCore/Scripts/lazywriter.py

Timestamp:

Sep 26, 2017, 8:34:19 AM (8 years ago)

Author:

[email protected]

Message:

JSC build should use unified sources for derived sources
​https://bugs.webkit.org/show_bug.cgi?id=177421

Reviewed by JF Bastien.

.:

• Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

This patch make a couple of changes:

1) Make derived sources added to relevant bundles. I was going to add JSCBuiltins.cpp
to runtime but that kept breaking the windows build. I'll get back to it later
2) Move the derived location of some sources both for clarity and for ease of use.
3) Make auto generator scripts able to create directories if needed.
4) Move some scripts from the top level of the JavaScriptCore directory to a
more appropriate directory.
5) Move some CMake generation commands around for clarity.

• CMakeLists.txt:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Scripts/lazywriter.py:

(LazyFileWriter.close):

• Sources.txt:
• inspector/scripts/generate-inspector-protocol-bindings.py:

(IncrementalFileWriter.close):

• yarr/create_regex_tables: Renamed from Source/JavaScriptCore/create_regex_tables.
• yarr/generateYarrCanonicalizeUnicode: Renamed from Source/JavaScriptCore/generateYarrCanonicalizeUnicode.

Source/WTF:

The script now needs to determine if a file is from a derived
source. This is only relevant for the CMake build since the
script needs to provide a list of the bundled source files. If the
script does not provide the full path for derived sources then
CMake will be unable to find them and the build will fail.

Additionally, I move the error message for the Xcode build outside
the main loop. This means that the error message will contain all
the files you need to add to Xcode and all those files will now be
written in DerivedSources so they should be easier to add.

• Scripts/generate-unified-source-bundles.rb:

File:

• trunk/Source/JavaScriptCore/Scripts/lazywriter.py (modified) (2 diffs)

trunk/Source/JavaScriptCore/Scripts/lazywriter.py

@@ -27 +27 @@
 # A writer that only updates file if it actually changed.
 
+import os
 
 class LazyFileWriter:
@@ -54 +55 @@
 
         if text_changed or self.force_output:
+            dirname = os.path.dirname(self._filepath)
+            if not os.path.isdir(dirname):
+                os.makedirs(dirname)
             out_file = open(self._filepath, "w")
             out_file.write(self._output)