Changeset 222689 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Oct 1, 2017, 10:23:29 AM (8 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r222564.
​https://bugs.webkit.org/show_bug.cgi?id=177720

"It regressed JetStream by 2% on iOS caused by a 50%
regression on the bigfib subtest" (Requested by saamyjoon on
#webkit).

Reverted changeset:

"Add Above/Below comparisons for UInt32 patterns"
​https://bugs.webkit.org/show_bug.cgi?id=177281
​http://trac.webkit.org/changeset/222564

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -189 +189 @@
         virtual bool isNewTarget() const { return false; }
         virtual bool isBytecodeIntrinsicNode() const { return false; }
-        virtual bool isBinaryOpNode() const { return false; }
 
         virtual void emitBytecodeInConditionContext(BytecodeGenerator&, Label&, Label&, FallThroughMode);
@@ -1066 +1065 @@
         ExpressionNode* rhs() { return m_expr2; };
 
-        bool isBinaryOpNode() const override { return true; }
-
-    private:
-        enum class UInt32Result { UInt32, Constant, };
-
+    private:
         void tryFoldToBranch(BytecodeGenerator&, TriState& branchCondition, ExpressionNode*& branchExpression);
         RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = 0) override;
@@ -1084 +1079 @@
     protected:
         bool m_rightHasAssignments;
-        bool m_shouldToUnsignedResult { true };
     };