Changeset 223069 in webkit for trunk/Source/JavaScriptCore/offlineasm/arm64.rb

Timestamp:

Oct 9, 2017, 2:17:14 PM (8 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r223015 and r223025.
​https://bugs.webkit.org/show_bug.cgi?id=178093

Regressed Kraken on iOS by 20% (Requested by keith_mi_ on
#webkit).

Reverted changesets:

"Enable gigacage on iOS"
​https://bugs.webkit.org/show_bug.cgi?id=177586
​http://trac.webkit.org/changeset/223015

"Unreviewed, disable Gigacage on ARM64 Linux"
​https://bugs.webkit.org/show_bug.cgi?id=177586
​http://trac.webkit.org/changeset/223025

File:

• trunk/Source/JavaScriptCore/offlineasm/arm64.rb (modified) (3 diffs)

trunk/Source/JavaScriptCore/offlineasm/arm64.rb

@@ -261 +261 @@
 end
 
-def arm64LowerLabelReferences(list)
-    newList = []
-    list.each {
-        | node |
-        if node.is_a? Instruction
-            case node.opcode
-            when "loadi", "loadis", "loadp", "loadq", "loadb", "loadbs", "loadh", "loadhs"
-                labelRef = node.operands[0]
-                if labelRef.is_a? LabelReference
-                    tmp = Tmp.new(node.codeOrigin, :gpr)
-                    newList << Instruction.new(codeOrigin, "globaladdr", [LabelReference.new(node.codeOrigin, labelRef.label), tmp])
-                    newList << Instruction.new(codeOrigin, node.opcode, [Address.new(node.codeOrigin, tmp, Immediate.new(node.codeOrigin, labelRef.offset)), node.operands[1]])
-                else
-                    newList << node
-                end
-            else
-                newList << node
-            end
-        else
-            newList << node
-        end
-    }
-    newList
-end
-
 # Workaround for Cortex-A53 erratum (835769)
 def arm64CortexA53Fix835769(list)
@@ -322 +297 @@
         result = riscLowerShiftOps(result)
         result = arm64LowerMalformedLoadStoreAddresses(result)
-        result = arm64LowerLabelReferences(result)
         result = riscLowerMalformedAddresses(result) {
             | node, address |
@@ -931 +905 @@
             $asm.puts "nop"
             $asm.putStr("#endif")
-        when "globaladdr"
-            uid = $asm.newUID
-            $asm.puts "L_offlineasm_loh_adrp_#{uid}:"
-            $asm.puts "adrp #{operands[1].arm64Operand(:ptr)}, #{operands[0].asmLabel}@GOTPAGE"
-            $asm.puts "L_offlineasm_loh_ldr_#{uid}:"
-            $asm.puts "ldr #{operands[1].arm64Operand(:ptr)}, [#{operands[1].arm64Operand(:ptr)}, #{operands[0].asmLabel}@GOTPAGEOFF]"
-            $asm.deferAction {
-                $asm.puts ".loh AdrpLdrGot L_offlineasm_loh_adrp_#{uid}, L_offlineasm_loh_ldr_#{uid}"
-            }
         else
             lowerDefault