Changeset 223584 in webkit for trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp

Timestamp:

Oct 17, 2017, 4:34:29 PM (8 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r223523.

A test for this change is failing on debug JSC bots.

Reverted changeset:

"[JSC] proto getter should be fast"
​https://bugs.webkit.org/show_bug.cgi?id=178067
​https://trac.webkit.org/changeset/223523

File:

• trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp

@@ -1601 +1601 @@
             fixEdge<Int32Use>(node->child1());
             fixEdge<Int32Use>(node->child2());
-            break;
-        }
-
-        case GetPrototypeOf: {
-            fixupGetPrototypeOf(node);
             break;
         }
@@ -2308 +2303 @@
     }
 
-    void fixupGetPrototypeOf(Node* node)
-    {
-        // Reflect.getPrototypeOf only accepts Objects. For Reflect.getPrototypeOf, ByteCodeParser attaches ObjectUse edge filter before fixup phase.
-        if (node->child1().useKind() != ObjectUse) {
-            if (node->child1()->shouldSpeculateString()) {
-                insertCheck<StringUse>(node->child1().node());
-                m_graph.convertToConstant(node, m_graph.freeze(m_graph.globalObjectFor(node->origin.semantic)->stringPrototype()));
-                return;
-            }
-            if (node->child1()->shouldSpeculateInt32()) {
-                insertCheck<Int32Use>(node->child1().node());
-                m_graph.convertToConstant(node, m_graph.freeze(m_graph.globalObjectFor(node->origin.semantic)->numberPrototype()));
-                return;
-            }
-            if (enableInt52() && node->child1()->shouldSpeculateAnyInt()) {
-                insertCheck<Int52RepUse>(node->child1().node());
-                m_graph.convertToConstant(node, m_graph.freeze(m_graph.globalObjectFor(node->origin.semantic)->numberPrototype()));
-                return;
-            }
-            if (node->child1()->shouldSpeculateNumber()) {
-                insertCheck<NumberUse>(node->child1().node());
-                m_graph.convertToConstant(node, m_graph.freeze(m_graph.globalObjectFor(node->origin.semantic)->numberPrototype()));
-                return;
-            }
-            if (node->child1()->shouldSpeculateSymbol()) {
-                insertCheck<SymbolUse>(node->child1().node());
-                m_graph.convertToConstant(node, m_graph.freeze(m_graph.globalObjectFor(node->origin.semantic)->symbolPrototype()));
-                return;
-            }
-            if (node->child1()->shouldSpeculateBoolean()) {
-                insertCheck<BooleanUse>(node->child1().node());
-                m_graph.convertToConstant(node, m_graph.freeze(m_graph.globalObjectFor(node->origin.semantic)->booleanPrototype()));
-                return;
-            }
-        }
-
-        if (node->child1()->shouldSpeculateFinalObject()) {
-            fixEdge<FinalObjectUse>(node->child1());
-            node->clearFlags(NodeMustGenerate);
-            return;
-        }
-        if (node->child1()->shouldSpeculateArray()) {
-            fixEdge<ArrayUse>(node->child1());
-            node->clearFlags(NodeMustGenerate);
-            return;
-        }
-        if (node->child1()->shouldSpeculateFunction()) {
-            fixEdge<FunctionUse>(node->child1());
-            node->clearFlags(NodeMustGenerate);
-            return;
-        }
-    }
-
     void fixupToThis(Node* node)
     {