Changeset 223645 in webkit for trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp

Timestamp:

Oct 18, 2017, 6:12:56 PM (8 years ago)

Author:

[email protected]

Message:

RegExpObject::defineOwnProperty() does not need to compare values if no descriptor value is specified.
​https://bugs.webkit.org/show_bug.cgi?id=177600
<rdar://problem/34710985>

Reviewed by Saam Barati.

JSTests:

• stress/regress-177600.js: Added.

Source/JavaScriptCore:

According to ​http://www.ecma-international.org/ecma-262/8.0/#sec-validateandapplypropertydescriptor,
section 9.1.6.3-7.a.ii, we should only check if the value is the same if the
descriptor value is present.

• runtime/RegExpObject.cpp:

(JSC::RegExpObject::defineOwnProperty):

File:

• trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp

@@ -121 +121 @@
             if (descriptor.writablePresent() && descriptor.writable())
                 return typeError(exec, scope, shouldThrow, ASCIILiteral(UnconfigurablePropertyChangeWritabilityError));
-            if (!sameValue(exec, regExp->getLastIndex(), descriptor.value()))
+            if (descriptor.value() && !sameValue(exec, regExp->getLastIndex(), descriptor.value()))
                 return typeError(exec, scope, shouldThrow, ASCIILiteral(ReadonlyPropertyChangeError));
             return true;