Changeset 223777 in webkit for trunk/Source/JavaScriptCore/runtime/JSModuleLoader.h

Timestamp:

Oct 20, 2017, 10:58:32 AM (8 years ago)

Author:

Matt Lewis

Message:

Unreviewed, rolling out r223744, r223750, and r223751.
​https://bugs.webkit.org/show_bug.cgi?id=178594

These caused consistent failures in test that existed and were
added in the patches. (Requested by mlewis13 on #webkit).

Reverted changesets:

"[JSC] ScriptFetcher should be notified directly from module
pipeline"
​https://bugs.webkit.org/show_bug.cgi?id=178340
​https://trac.webkit.org/changeset/223744

"Unreviewed, fix changed line number in test expect files"
​https://bugs.webkit.org/show_bug.cgi?id=178340
​https://trac.webkit.org/changeset/223750

"Unreviewed, follow up to reflect comments"
​https://bugs.webkit.org/show_bug.cgi?id=178340
​https://trac.webkit.org/changeset/223751

Patch by Commit Queue <​[email protected]> on 2017-10-20

File:

• trunk/Source/JavaScriptCore/runtime/JSModuleLoader.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSModuleLoader.h

@@ -69 +69 @@
     JSValue linkAndEvaluateModule(ExecState*, JSValue moduleKey, JSValue scriptFetcher);
     JSInternalPromise* requestImportModule(ExecState*, const Identifier&, JSValue parameters, JSValue scriptFetcher);
-    JSValue notifyCompleted(ExecState*, JSValue scriptFetcher, JSValue key);
-    JSValue notifyFailed(ExecState*, JSValue scriptFetcher, JSValue error);
 
     // Platform dependent hooked APIs.